1606191 - orderfile.txt has no update machinery

Status: RESOLVED FIXED

(Firefox Build System :: General, defect)

Description

[Masatoshi Kimura [:emk]]

According to the check-in comment, "It's OK if these files are
slightly out of date." But this file is not updated after the first check-in (except bug 1560455.)

I'm trying to change decorated symbols manually in bug 1606050. It's messy. It would be great if it is done automatically.

Comment 1

[(Away)]

A few weeks ago I tried doing a full re-generate by adding back the function instrumentation (I noticed a large amount of staleness from the JS::Value changes among others) but I didn't see any measurable improvement. Also at one point we accidentally stopped using order files and our perf benchmarks didn't complain. Which kind of suggests that the order files aren't helping at all, except that when I tried removing them, I did see a very small but consistent loss (I guess it's not large enough for perf benchmarks to generate an alert).

So: if you have an easy sed-style update to the files, that seems like an uncontroversial r+, but a larger change to machinery might not be worthwhile at this point.

Comment 2

[[:sergesanspaille]]

Attachment: Bug 1606191 - Remove hand-written Windows orderfile r=glandium

Since 1839832 we generate an equivalent file based on PGO data
automatically.

Comment 3

[Masatoshi Kimura [:emk]]

Bug 1839832 is backed out.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/b9e53259259d
Remove hand-written Windows orderfile r=glandium

Comment 5

[Cristina Horotan [:chorotan]]

https://hg.mozilla.org/mozilla-central/rev/b9e53259259d