1606195 - PiP - Problem with Udemy "Next video" arrow. The arrow appears in the from of PiP button

Status: VERIFIED FIXED

(Toolkit :: Video/Audio Controls, defect, P3)

Description

[Wellington Torrejais da Silva]

Attachment: Screenshot (5).png

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:73.0) Gecko/20100101 Firefox/73.0

Steps to reproduce:

Open Udemy course:
https://www.udemy.com/course/master-emberjs/learn/lecture/3101430?start=0#overview

When try to using PiP to see lessons video during do other things.
The PiP button is overloaded by custom player "next video" button

Actual results:

Can't do right click actions
Can't click in PiP button
PiP button overloaded by custom player button

Expected results:

Ways to click in PiP button

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

Bugbug thinks this bug should belong to this component, but please revert this change in case of error.

Comment 2

[Mike Conley (:mconley) (:⚙️)]

Thanks, Wellington.

This might be a good opportunity to use the new policies system to shift the toggle to somewhere else on Udemy.

Comment 3

[Mike Conley (:mconley) (:⚙️)]

Attachment: Bug 1606195 - Adjust Picture-in-Picture toggle to be at 25% from the top for Udemy videos. r?denschub

Depends on D61009

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/48dfd254e98e
Adjust Picture-in-Picture toggle to be at 25% from the top for Udemy videos. r=denschub

Comment 5

[Daniel Varga [:dvarga]]

https://hg.mozilla.org/mozilla-central/rev/48dfd254e98e

Comment 6

[Wellington Torrejais da Silva]

Thanks!

Comment 7

[Alin Ilea, Desktop QA]

Reproduced the initial issue in Release version 73.0 using Windows 10.
Verified - Fixed in Beta 74.0b4 (Build id: 20200216164042) and latest Nightly 75.0a1 (Build id: 20200216210001) using Windows 10, Ubuntu 18.04 and Mac OS 10.15

Comment 8

[wicker25]

Hi folks,

I just found this thread and I wanted to thank you for the fix. However the same issue is still affecting the UFB domains and some other ones used by our students.

I would suggest you to apply the same fix for all the domains *.udemy.com:

// Udemy
"https://*.udemy.com/*": TOGGLE_POLICIES.ONE_QUARTER

Thank you again for your work,

Giacomo @ Udemy, Inc

Comment 9

[Mike Conley (:mconley) (:⚙️)]

(In reply to wicker25 from comment #8)

Thank you again for your work,

Giacomo @ Udemy, Inc

Thanks, Giacomo! I've filed bug 1619110, and I'll see if I can get that uplifted to Firefox 74.