Open Bug 1606289 Opened 9 months ago Updated 9 months ago

Crash in [@ <name omitted> | mozilla::gfx::SourceSurfaceSkia::~SourceSurfaceSkia]

Categories

(Core :: Graphics: Layers, defect, P3)

x86_64
macOS
defect

Tracking

()

Tracking Status
firefox-esr68 --- unaffected
firefox72 --- wontfix
firefox73 --- affected
firefox74 --- affected

People

(Reporter: gsvelto, Assigned: jrmuizel)

Details

(Keywords: crash)

Crash Data

Attachments

(1 file)

This bug is for crash report bp-80915731-4540-4b4b-ac13-d81790191229.

Top 10 frames of crashing thread:

0 libmozglue.dylib <name omitted> mozglue/misc/Mutex_posix.cpp:119
1 XUL mozilla::gfx::SourceSurfaceSkia::~SourceSurfaceSkia gfx/2d/SourceSurfaceSkia.cpp:25
2 XUL mozilla::gfx::SourceSurfaceSkia::~SourceSurfaceSkia gfx/2d/SourceSurfaceSkia.cpp:25
3 XUL mozilla::gfx::DrawTargetSkia::~DrawTargetSkia gfx/2d/DrawTargetSkia.cpp:296
4 XUL mozilla::gfx::DrawTargetSkia::~DrawTargetSkia gfx/2d/DrawTargetSkia.cpp:278
5 XUL mozilla::gfx::DrawTargetOffset::~DrawTargetOffset gfx/2d/DrawTargetOffset.h:46
6 XUL nsSVGMaskFrame::GetMaskForMaskedFrame layout/svg/nsSVGMaskFrame.cpp:136
7 XUL CreateAndPaintMaskSurface layout/svg/nsSVGIntegrationUtils.cpp:541
8 XUL nsSVGIntegrationUtils::PaintMaskAndClipPath layout/svg/nsSVGIntegrationUtils.cpp:1046
9 XUL nsDisplayMasksAndClipPaths::PaintAsLayer layout/painting/nsDisplayList.cpp:10058

Low-volume macOS-specific crash that seems to have started in nightly 69 (the oldest crash we have on file is for buildid 20190701095406). The raw crash reason is:

MOZ_CRASH(mozilla::detail::MutexImpl::~MutexImpl: pthread_mutex_destroy failed)

However all crashes have the GraphicsCriticalError annotation set to something like this:

|[C0][GFX1-]: Failed to allocate a surface due to invalid size (DSS) Size(13312,13312) (t=2754.51)

Flags: needinfo?(lsalzman)
Priority: -- → P3

Jeff, this looks like a DrawTargetOffset bug potentially?

Flags: needinfo?(lsalzman) → needinfo?(jmuizelaar)
Assignee: nobody → jmuizelaar
Status: NEW → ASSIGNED
Pushed by jmuizelaar@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/f2d8fcb06429
SourceSurfaceSkia: Assert we're not locked during destruction. r=lsalzman
Status: ASSIGNED → RESOLVED
Closed: 9 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla74

Is this something we should consider uplifting to Beta or is this just trading one crash for a different one?

We don't need to uplift as it's just trading crashes.

Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Status: REOPENED → NEW
Target Milestone: mozilla74 → ---
Flags: needinfo?(jmuizelaar)
You need to log in before you can comment on or make changes to this bug.