1606289 - Crash in [@ <name omitted> | mozilla::gfx::SourceSurfaceSkia::~SourceSurfaceSkia]

Status: RESOLVED WORKSFORME

(Core :: Graphics: Layers, defect, P3)

Description

[Gabriele Svelto [:gsvelto]]

This bug is for crash report bp-80915731-4540-4b4b-ac13-d81790191229.

Top 10 frames of crashing thread:

0 libmozglue.dylib <name omitted> mozglue/misc/Mutex_posix.cpp:119
1 XUL mozilla::gfx::SourceSurfaceSkia::~SourceSurfaceSkia gfx/2d/SourceSurfaceSkia.cpp:25
2 XUL mozilla::gfx::SourceSurfaceSkia::~SourceSurfaceSkia gfx/2d/SourceSurfaceSkia.cpp:25
3 XUL mozilla::gfx::DrawTargetSkia::~DrawTargetSkia gfx/2d/DrawTargetSkia.cpp:296
4 XUL mozilla::gfx::DrawTargetSkia::~DrawTargetSkia gfx/2d/DrawTargetSkia.cpp:278
5 XUL mozilla::gfx::DrawTargetOffset::~DrawTargetOffset gfx/2d/DrawTargetOffset.h:46
6 XUL nsSVGMaskFrame::GetMaskForMaskedFrame layout/svg/nsSVGMaskFrame.cpp:136
7 XUL CreateAndPaintMaskSurface layout/svg/nsSVGIntegrationUtils.cpp:541
8 XUL nsSVGIntegrationUtils::PaintMaskAndClipPath layout/svg/nsSVGIntegrationUtils.cpp:1046
9 XUL nsDisplayMasksAndClipPaths::PaintAsLayer layout/painting/nsDisplayList.cpp:10058

Low-volume macOS-specific crash that seems to have started in nightly 69 (the oldest crash we have on file is for buildid 20190701095406). The raw crash reason is:

MOZ_CRASH(mozilla::detail::MutexImpl::~MutexImpl: pthread_mutex_destroy failed)

However all crashes have the GraphicsCriticalError annotation set to something like this:

|[C0][GFX1-]: Failed to allocate a surface due to invalid size (DSS) Size(13312,13312) (t=2754.51)

Comment 1

[Lee Salzman [:lsalzman]]

Jeff, this looks like a DrawTargetOffset bug potentially?

Comment 2

[Jeff Muizelaar [:jrmuizel]]

Attachment: Bug 1606289: SourceSurfaceSkia: Assert we're not locked during destruction.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/f2d8fcb06429
SourceSurfaceSkia: Assert we're not locked during destruction. r=lsalzman

Comment 4

[Noemi Erli[:noemi_erli]]

https://hg.mozilla.org/mozilla-central/rev/f2d8fcb06429

Comment 5

[Ryan VanderMeulen [:RyanVM]]

Is this something we should consider uplifting to Beta or is this just trading one crash for a different one?

Comment 6

[Jeff Muizelaar [:jrmuizel]]

We don't need to uplift as it's just trading crashes.

Comment 7

[BugBot [:suhaib / :marco/ :calixte]]

Closing because no crashes reported for 12 weeks.