1606316 - About Firefox Nightly window not rendered correctly on integrated GPU's while Fission is enabled and WebRender disabled

Status: RESOLVED WONTFIX

(Core :: Graphics, defect, P3)

Description

[Vlad Lucaci, Thunderbird QA (:vlucaci)]

Attachment: fission-about FF.png

Affected versions

• 73.0a1(ID:20191229212642)

Affected platforms

• Windows 10

Steps to reproduce

1. Launch FF.
2. Go to about:config.
3. Toggle fission.autostart pref to true.
4. Restart FF.
5. Go to hamburger menu and select Help-> About Nightly.

Expected result

• About Firefox Nightly window is properly displayed, with all relevant information.

Actual result

• About Firefox Nightly window is not properly displayed, with all section being blank, or only small portions being displayed.

Regression range

• Will return with a regression ASAP.

Additional notes

• This issue only occurs on integrated GPU's such as the following:

• Intel HD 4400
• Intel HD 2500
• Qualcomm Adreno 630

• This issue WAS NOT reproduced at all on dedicated GPU such as:

• ATI Radeon 3000
• AMD Radeon R7 M340

Comment 1

[Jessie [:jbonisteel] pls NI]

Just out of curiosity, do you also have WebRender enabled?

Comment 2

[Vlad Lucaci, Thunderbird QA (:vlucaci)]

Hello Jessie,

WebRender is disabled when reproducing this issue. The only pref changed in order to reproduce this is fission.autostart set to true.

Comment 3

[BugBot [:suhaib / :marco/ :calixte]]

Bugbug thinks this bug is a regression, but please revert this change in case of error.

Comment 4

[Jessie [:jbonisteel] pls NI]

Can you try enabling WebRender and tell me if the issue still happens?

Comment 5

[Chris Peterson [:cpeterson]]

Fission will require WebRender. If this bug is only reproducible when WebRender is disabled, then it will probably be a low priority or a WONTFIX bug.

Comment 6

[Emil Ghitta, QA [:emilghitta]]

This behavior is not reproducible if having both fission.autostart and gfx.webrender.all set to true . This seems to be only reproducible while WebRender is disabled and Fission enabled.

Tested on devices with Qualcomm Adreno 630 and Intel HD 4400 GPU's.

Comment 7

[Chris Peterson [:cpeterson]]

(In reply to Emil Ghitta, QA [:emilghitta] from comment #6)

This behavior is not reproducible if having both fission.autostart and gfx.webrender.all set to true . This seems to be only reproducible while WebRender is disabled and Fission enabled.

Emil, thanks for confirming. Based on your findings, this bug doesn't need to block Fission MVP.

Comment 8

[Chris Peterson [:cpeterson]]

(In reply to Emil Ghitta, QA [:emilghitta] from comment #6)

This behavior is not reproducible if having both fission.autostart and gfx.webrender.all set to true . This seems to be only reproducible while WebRender is disabled and Fission enabled.

Emil, thanks for confirming. Based on your findings, this bug doesn't need to block Fission MVP.

Comment 9

[Patrick (he/him)]

Regression window for this bug appears to be last good build 2019-11-24, first broken build 2019-11-25. From mozregression:

Narrowed inbound regression window from [844707d4, fec93f89] (3 builds) to [844707d4, 228dea1e] (2 builds) (~1 steps left)
2020-01-08T12:12:29: DEBUG : Starting merge handling...
2020-01-08T12:12:29: DEBUG : Using url: https://hg.mozilla.org/integration/autoland/json-pushes?changeset=228dea1ec34951b2381c70fd90f81a300ece141d&full=1
2020-01-08T12:12:31: DEBUG : Found commit message:
Bug 1586411 - Don't crash if AttachLayerManager fails. r=rhunt

Differential Revision: https://phabricator.services.mozilla.com/D53760

Comment 10

[Chris Peterson [:cpeterson]]

(In reply to mpj.5 from comment #9)

2020-01-08T12:12:31: DEBUG : Found commit message:
Bug 1586411 - Don't crash if AttachLayerManager fails. r=rhunt

I was surprised that bug 1586411 might have caused this "About Firefox" bug (because that bug simply removed a MOZ_CRASH), so I tried bisecting this bug again. And I hit the same regression range! However, I noticed that the pushlog included two changesets. I think the other changeset, Advanced Layers bug 1588484, is probably the cause of this bug:

https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=844707d4b9ef69eed91400566eb5d0d46956de0d&tochange=228dea1ec34951b2381c70fd90f81a300ece141d

Note that this bug is still a low priority because we plan to require WebRender to use Fission.

Comment 11

[Alexandru Trif, Desktop Test Engineering [:atrif]]

Attachment: facebook_login.png

Hello! I can reproduce a similar issue with fission.autostart on true and WebRender disabled using Firefox 74.0a1 (20200127213955) on pages with saved login information (e.g Facebook, Twitter). The dropdown for autocomplete is rendered black as seen in the attached screenshot. Should I open a new bug on this or this is the same as this one? Thanks!

Comment 12

[Chris Peterson [:cpeterson]]

(In reply to Alexandru Trif, QA [:atrif] from comment #11)

Hello! I can reproduce a similar issue with fission.autostart on true and WebRender disabled using Firefox 74.0a1 (20200127213955) on pages with saved login information (e.g Facebook, Twitter). The dropdown for autocomplete is rendered black as seen in the attached screenshot. Should I open a new bug on this or this is the same as this one?

I don't think we need to open a new bug. The Firefox About window uses HTML, so it's probably just a special case of the saved login problem you see.

Also enabling Fission without WebRender is not an officially supported configuration. We plan to require enabling WebRender when using Fission.

Comment 13

[Hiroyuki Ikezoe (:hiro)]

I had seen this before but I think now it works fine?

Comment 14

[Emil Ghitta, QA [:emilghitta]]

Hi Hiroyuki,

Vlad is currently in PTO. I can still see this issue reproducible using Friefox 75.0a1 (BuildId:20200216210001) with Fission enabled and Webrender disabled on Windows 10 (with the following integrated GPU's: Intel HD 4400 and Intel HD Graphics 630).

Comment 15

[Chris Peterson [:cpeterson]]

WONTFIX because we've decided we won't support Fission without WebRender.

Comment 16

[Chris Peterson [:cpeterson]]

Reopening and tracking for Fission M7 Beta because we might need to support Fission on Windows without WebRender after all.

Comment 17

[Chris Peterson [:cpeterson]]

We plan to allow Fission on macOS and Linux without WR, so we will want to fix this painting bug.

Comment 18

[Chris Peterson [:cpeterson]]

Moving Fission-without-WebRender backs to Fission Future because we are assuming again Fission MVP can depend on WebRender (via SW-WR) being enabled for all platforms.

Comment 19

[Neha Kochar [:neha]]

Fission will require WR so we don't need to fix this.