Open
Bug 1606352
Opened 5 years ago
Updated 2 years ago
HashMap's putNew should assert on more than just debug builds
Categories
(Core :: MFBT, task)
Core
MFBT
Tracking
()
NEW
People
(Reporter: alexical, Unassigned)
Details
I was failing this assertion in bug 1606102. It doesn't look like there would be severe consequences from this, but I can't guarantee that across all usages of putNew. Additionally I can't guarantee that there are no problems within HashMap's implementation that could arise from erroneous putNew usages.
froydnj suggested this should be a release or diagnostic assert, and I think I agree. We should probably start with MOZ_DIAGNOSTIC_ASSERT and go from there, because it's unclear at the outset what the ratio of noisy breakage to useful breakage might be.
|
||
Updated•2 years ago
|
Severity: normal normal → S3 S3
You need to log in
before you can comment on or make changes to this bug.
Description
•