Closed Bug 1606366 Opened 5 years ago Closed 5 years ago

[wpt-sync] Sync PR 20953 - Portals: Use WebContents::ClosePage to run unload handlers for portals.

Categories

(Testing :: web-platform-tests, task, P4)

Product:
Testing
Component:
web-platform-tests
Type:
task

Tracking

(firefox74 fixed)

Status:
RESOLVED FIXED
Milestone:
mozilla74
Tracking Flags:
Tracking Status
firefox74 --- fixed

People

(Reporter: wpt-sync, Unassigned)

References

(
URL
)

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 20953 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/20953
Details from upstream follow.

Jeremy Roman <jbroman@chromium.org> wrote:

Portals: Use WebContents::ClosePage to run unload handlers for portals.

On the way, refactor how the Portal \<-> WebContentsImpl pointers are
maintained, as this work caused the raw WebContentsImpl* to dangling while
writing the main code of this CL, which made for a confusing bug. This
refactoring is mainly a mechanical gathering of the code responsible for
updating these into a small nested class.

Bug: 964481
Change-Id: I8a63e1a5531de4807569b35ea0f3fcb19baf343c

Reviewed-on: https://chromium-review.googlesource.com/1976000
WPT-Export-Revision: 296cc9f444b87e6744418996deb57dc9053c6203

CI Results

Ran 0 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 1 tests and 2 subtests

Status Summary

Firefox

FAIL : 1
TIMEOUT: 2

Chrome

FAIL : 1
TIMEOUT: 2

Safari

FAIL : 1
TIMEOUT: 2

Links

GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

/portals/predecessor-fires-unload.html: TIMEOUT (Chrome: TIMEOUT, Safari: TIMEOUT)
pagehide and unload should fire if the predecessor is not adopted: FAIL (Chrome: FAIL, Safari: FAIL)
pagehide and unload should fire if the predecessor is not adopted, even without a window/opener association: TIMEOUT (Chrome: TIMEOUT, Safari: TIMEOUT)

CI Results

Ran 13 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 40 tests

Status Summary

Firefox

PASS : 39
FAIL : 1
TIMEOUT: 2

Chrome

FAIL : 1
TIMEOUT: 2

Safari

FAIL : 1
TIMEOUT: 2

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

/portals/predecessor-fires-unload.html: TIMEOUT (Chrome: TIMEOUT, Safari: TIMEOUT)
pagehide and unload should fire if the predecessor is not adopted: FAIL (Chrome: FAIL, Safari: FAIL)
pagehide and unload should fire if the predecessor is not adopted, even without a window/opener association: TIMEOUT (Chrome: TIMEOUT, Safari: TIMEOUT)

Pushed by wptsync@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/e12b610b184c [wpt PR 20953] - Portals: Use WebContents::ClosePage to run unload handlers for portals., a=testonly https://hg.mozilla.org/integration/autoland/rev/229067c22c35 [wpt PR 20953] - Update wpt metadata, a=testonly

https://hg.mozilla.org/mozilla-central/rev/e12b610b184c
https://hg.mozilla.org/mozilla-central/rev/229067c22c35

Status: NEW → RESOLVED
Closed: 5 years ago
status-firefox74: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla74
You need to log in before you can comment on or make changes to this bug.