Closed Bug 1606375 Opened 5 years ago Closed 5 years ago

Components loaded multiple times

Categories

(Calendar :: Internal Components, defect)

defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED
68.5.0

People

(Reporter: darktrojan, Assigned: darktrojan)

Details

Attachments

(1 file)

I made a mistake in bug 1590665, and discovered that all the files listed in calItemModule.js are read over and over, despite the attempt to prevent this happening by replacing NSGetFactory with its result. It seems the original function is used every time.

Attachment #9118109 - Flags: review?(philipp)
Attachment #9118109 - Flags: approval-calendar-esr?(philipp)
Attachment #9118109 - Flags: review?(philipp)
Attachment #9118109 - Flags: review+
Attachment #9118109 - Flags: approval-calendar-esr?(philipp)
Attachment #9118109 - Flags: approval-calendar-esr+

Pushed by geoff@darktrojan.net:
https://hg.mozilla.org/comm-central/rev/6ff2528049d8
Prevent calendar components from being loaded multiple times; r=Fallen

Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → 74
Comment on attachment 9118109 [details] [diff] [review] 1606375-components-once-1.diff Clearly I did this at a time when it was expected on beta automatically.
Attachment #9118109 - Flags: approval-calendar-beta?(philipp)
Attachment #9118109 - Flags: approval-calendar-beta?(philipp)
Target Milestone: 74 → 68.5.0
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: