1606383 - Update docker-compose format version

Status: RESOLVED FIXED

(Conduit :: Phabricator, enhancement)

Description

[Mitchell Hentges [:mhentges] 🦀]

For bug 1605890, I'd like to have a single phabricator Dockerfile with multiple stages (one for development and one for production).
Then, in docker-compose.phabricator.yml, I want to "target" the development stage.

However, services.*.build.target was only added to docker-compose in version 3.4, and we're on version 2.0.

I'd like to update our docker-compose files to version 3.4, which will require that developers are using docker engine 17.09.0 or higher.

I don't believe we use docker-compose in production, so this shouldn't affect ops.

Comment 1

[Mitchell Hentges [:mhentges] 🦀]

Attachment: Bug 1606383 - update docker-compose version to 3.4

The only breaking change is that "volumes_from" no longer exists. So, I had to enumerate the volumes of each
image + service config and encode them where a ".test" service would have done "volumes_from".

In the "docker-compose.*.yml" files where the shared volume was a file/dir on the host file system, I separately defined
the volume in the top-level "volumes" section and had the associated services refer to that.
I used http://blog.code4hire.com/2018/06/define-named-volume-with-host-mount-in-the-docker-compose-file/ as a reference here.