1606392 - Match Case setting not respected after page reload

Status: RESOLVED FIXED

(Core :: Find Backend, defect, P1)

Description

[glyphimor]

User Agent: Mozilla/5.0 (X11; Linux x86_64; rv:71.0) Gecko/20100101 Firefox/71.0

Steps to reproduce:

1. Go to the Firefox homepage.

2. Press Ctrl-F and, with the Match Case option off, type in "browser". There are 7 matches. F3 cycles between matches.

3. Click Match Case. There are now 2 matches. F3 cycles between matches.

4. Reload the page, either by actually reloading, going back then forward, or going forward then back.

Actual results:

The search bar still has Match Case selected and says there are 2 matches, but after hitting F3, it changes to 7 matches, and F3 cycles between all 7. Match Case still shows as being selected, but isn't being respected.

To get Firefox to correctly "remember" the Match Case setting, you have to flip it off and then back on, or edit the search bar text field.

Expected results:

After reloading the page and hitting F3, the Match Case setting should be respected.

Comment 1

[Alice0775 White]

Regression window:
https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=5b303cb0a0a39e2bd4a6fea53535fe8e1d829b97&tochange=e33c3e14ee40f88d1775952e309dc2a617eb97f7

Comment 2

[Neil Deakin]

Attachment: Bug 1606392, pass along and update the match case, diacriticals and whole word state to the child for each find attempt, r=mikedeboer

Comment 3

[BugBot [:suhaib / :marco/ :calixte]]

The priority flag is not set for this bug.
:mikedeboer, could you have a look please?

For more information, please visit auto_nag documentation.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/2af05f5f68ed
pass along and update the match case, diacriticals and whole word state to the child for each find attempt, r=mikedeboer

Comment 6

[Razvan Maries]

https://hg.mozilla.org/mozilla-central/rev/2af05f5f68ed