Closed Bug 1606392 Opened 4 years ago Closed 4 years ago

Match Case setting not respected after page reload

Categories

(Core :: Find Backend, defect, P1)

Product:
Core
Component:
Find Backend
Version:
71 Branch
Type:
defect

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla75
Tracking Flags:
Tracking Status
firefox-esr68 --- unaffected
firefox71 --- wontfix
firefox72 --- wontfix
firefox73 --- wontfix
firefox74 --- wontfix
firefox75 --- fixed

People

(Reporter: glyphimor, Assigned: enndeakin)

References

(Regression)

Details

(Keywords: regression)

Attachments

(1 file)

Bug 1606392, pass along and update the match case, diacriticals and whole word state to the child for each find attempt, r=mikedeboer
47 bytes, text/x-phabricator-request
Details | Review

User Agent: Mozilla/5.0 (X11; Linux x86_64; rv:71.0) Gecko/20100101 Firefox/71.0

Steps to reproduce:

  1. Go to the Firefox homepage.

  2. Press Ctrl-F and, with the Match Case option off, type in "browser". There are 7 matches. F3 cycles between matches.

  3. Click Match Case. There are now 2 matches. F3 cycles between matches.

  4. Reload the page, either by actually reloading, going back then forward, or going forward then back.

Actual results:

The search bar still has Match Case selected and says there are 2 matches, but after hitting F3, it changes to 7 matches, and F3 cycles between all 7. Match Case still shows as being selected, but isn't being respected.

To get Firefox to correctly "remember" the Match Case setting, you have to flip it off and then back on, or edit the search bar text field.

Expected results:

After reloading the page and hitting F3, the Match Case setting should be respected.

Component: Untriaged → Find Toolbar
Product: Firefox → Toolkit

Regression window:
https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=5b303cb0a0a39e2bd4a6fea53535fe8e1d829b97&tochange=e33c3e14ee40f88d1775952e309dc2a617eb97f7

Status: UNCONFIRMED → NEW
Has Regression Range: --- → yes
Has STR: --- → yes
status-firefox71: --- → wontfix
status-firefox72: --- → wontfix
status-firefox73: --- → affected
status-firefox-esr68: --- → unaffected
Component: Find Toolbar → Find Backend
Ever confirmed: true
Keywords: regression
Product: Toolkit → Core
Regressed by: 1553384
Assignee: nobody → enndeakin
Status: NEW → ASSIGNED
Flags: needinfo?(enndeakin)

The priority flag is not set for this bug.
:mikedeboer, could you have a look please?

For more information, please visit auto_nag documentation.

Flags: needinfo?(mdeboer)
Flags: needinfo?(mdeboer)
Priority: -- → P1
Pushed by neil@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/2af05f5f68ed
pass along and update the match case, diacriticals and whole word state to the child for each find attempt, r=mikedeboer

https://hg.mozilla.org/mozilla-central/rev/2af05f5f68ed

Status: ASSIGNED → RESOLVED
Closed: 4 years ago
status-firefox75: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla75
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: