1606575 - Need a formatFileSize API

Status: RESOLVED FIXED

(Thunderbird :: Add-Ons: Extensions API, enhancement)

Description

[Mark Banner (:standard8)]

nsIMessenger.formatFileSize is used throughout Thunderbird to provide a consistent file size formatting for users.

Whilst WebExtensions could simulate it, it would seem better to expose it via an API so that it could be consistent.

We can't expose it only where we have APIs that return sizes, as a WebExtension may be displaying other sizes (e.g. pending attachments) that need to be formatted.

Comment 1

[John Bieling (:TbSync)]

Attachment: Bug 1606575 - Add messengerUtilities API including a formatFileSize() method. r=#thunderbird-reviewers

This API will be populated with utility methods useful for extension
developers. The main goal is to be consistent across add-ons and not
forcing add-ons to re-invent methods which already exist in Thunderbird.

If Thunderbrid decides to change the output of these functions, all
add-ons using them will automatically be adjusted as well.

Comment 2

[John Bieling (:TbSync)]

Attachment: Bug 1606575 - Add parseMailboxString() to messengerUtilities API. r=#thunderbird-reviewers

Currently add-on developers try to do manual parsing, which is error
prone. It is true that they could load a third party library, but
exposing this makes it so much easier.

Depends on D204473

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/11c83faa7fe0
Add messengerUtilities API including a formatFileSize() method. r=mkmelin
https://hg.mozilla.org/comm-central/rev/5ce39dffae42
Add parseMailboxString() to messengerUtilities API. r=mkmelin

Comment 4

[John Bieling (:TbSync)]

Attachment: Bug 1606575 - Follow-up to fix locale issue with formatFileSize. r=#thunderbird-reviewers

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/3ffef1eed480
Follow-up to fix locale issue with formatFileSize. r=benc

Comment 6

[John Bieling (:TbSync)]

Attachment: Bug 1606575 - Follow-up to fix missing "optional" property in schema definition. r=#thunderbird-reviewers

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/e0343a9db270
Follow-up to fix missing "optional" property in schema definition. r=mkmelin