1606655 - Alt Codes Malfunction with the Programmer Dvorak Keyboard Layout

Status: VERIFIED FIXED

(Core :: DOM: UI Events & Focus Handling, defect, P3)

Description

[James.Smith_Bugzilla]

User Agent: Mozilla/5.0 (Windows NT 6.1; Win64; x64; rv:71.0) Gecko/20100101 Firefox/71.0

Steps to reproduce:

1. Install Programmer Dvorak — https://www.kaufmann.no/roland/dvorak/ — on a Windows 7 Ultimate 64-bit system.
2. Open Firefox and select any field where text can be entered — like the address bar, or "add a public comment" field on YouTube.
3. Hold ALT and then type 0153 on the NumPad.
4. Release ALT.

Actual results:

With the alt key pressed, when you hit NumPad 5, the Edit menu pops up, as if you pressed ALT+e. This only happens in Firefox (with the Programmer Dvorak layout). All other programs I've tested behave as expected with the Programmer Dvorak layout.

Expected results:

1. Nothing should happen until the ALT key is released.
2. When the ALT key is released the Trade Mark Sign (™) should appear behind the cursor, as if you typed it.

Comment 1

[Clara Guerrero ( Need Info Brindusa Tot Please)]

Hi James,

Thanks for the details. I was able to reproduce on Windows 7 and 8, on Firefox Nightly version 74.0a1 (2020-01-07) (64-bit), Release 72.0 (64-bit) and Beta 73.015 (64-bit).

I've chosen a component so that the issue is reviewed.

Best regards, Clara.

Comment 2

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

I'll check it next week (I hope I have much time).

Comment 3

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Hmm, it's tricky layout. Shift + Numpad5 inputs e, this e is used at resolving mnemonic. Perhaps, we should use altnative keycodes when the combination of Alt and Numpad[0-9].

Comment 4

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: Bug 1606655 - Make `NativeKey` stop adding alternative char codes while user inputs a Unicode character with `Alt` + some numpad keys r=m_kato!

Custom keyboard layout may set unusual character to each numpad key. In our
shortcut and acceleration key handling, we refer alternative char code values
stored in eKeyDown or eKeyPress and they may contain an alphabet which is
used by menubar but it shouldn't be performed while user inputs a Unicode
character with Alt + numpad keys because it's being handled by Windows.
(In strictly speaking, I think that we shouldn't dispatch key events of the
sequence, but Chrome does it so that we should keep dispatching for web-compat.)

This patch makes NativeKey stores same mCommittedCharsAndModifiers,
mShiftedString and mUnshiftedString values as usual keyboard layout
even active keyboard layout customized numpad key values.

Note that Windows handles the key sequence without virtual key code, meaning
that even if the numpad keys are shuffled by keyboard layout, typed numbers
are computed from physical key position. E.g., even if Numpad7 is mapped
to 1, it's treated as 7. Therefore, this patch refers scan code in
some places.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/b94005dcae81
Make `NativeKey` stop adding alternative char codes while user inputs a Unicode character with `Alt` + some numpad keys r=m_kato

Comment 6

[Alexandru Michis [:malexandru]]

https://hg.mozilla.org/mozilla-central/rev/b94005dcae81

Comment 7

[Clara Guerrero ( Need Info Brindusa Tot Please)]

Hi,

I've tested this using Firefox Nightly version 74.0a1 ( 2020-01-30) (64-bit),and and Beta 74.0b3 for windows 7 and the issue is not reproducible anymore. Based on this I will mark v74 flag and bug's status as verified.

I also verified the fix in latest nightly 75.0a1 and the issue is not reproducible there either.

Best,
Clara