1606781 - Disable LSNG in 72

Status: RESOLVED FIXED

(Core :: Storage: localStorage & sessionStorage, task, P1)

Description

[Jan Varga [:janv]]

We can't ship it on Release until storage initialization failures are addressed.

Comment 1

[Jan Varga [:janv]]

Attachment: Bug 1606781 - Disable LSNG in 72; r=asuth

Comment 2

[Jan Varga [:janv]]

Try push:
https://treeherder.mozilla.org/#/jobs?repo=try&revision=42cd9529210c9c39ae6151aec5c89dd87451e4a1

Only c3 on win debug failed and that can be easily fixed by increasing the number of expected assertions, like in bug 1581722.

Comment 3

[Jan Varga [:janv]]

Comment on attachment 9118464 [details]
Bug 1606781 - Disable LSNG in 72; r=asuth

Beta/Release Uplift Approval Request

• User impact if declined: If LSNG is enabled, LocalStorage depends on QuotaManager storage which is currently broken for some users. We don't want to ship LSNG until the issue is fixed.
• Is this code covered by automated tests?: Yes
• Has the fix been verified in Nightly?: No
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): This patch just disables LSNG, so the old implementation of LocalStorage will be used in FF 72. We fully support downgrading of LocalStorage data, so if some users already tried a beta build, they should be safe. We disabled LSNG in previous beta cycles and there were no problems reported after the switch.
• String changes made/needed: None

Comment 4

[Jan Varga [:janv]]

I requested an approval before actual r+, so please wait a bit, thanks.

Comment 5

[Jan Varga [:janv]]

I talked with :asuth yesterday and he agreed that we are going to disable it in 72.

Comment 6

[Julien Cristau [:jcristau] (back April 22)]

Comment on attachment 9118464 [details]
Bug 1606781 - Disable LSNG in 72; r=asuth

The same changes were reviewed in bug 1594299 and bug 1581722, I think that's good enough; approved for 72.0-build4.

Comment 7

[Julien Cristau [:jcristau] (back April 22)]

https://hg.mozilla.org/releases/mozilla-release/rev/e28eb9c8b1ad

Comment 8

[Ryan VanderMeulen [:RyanVM]]

Hi Jan, can you please file the Fx73 bug and CC me to it? Thanks!

Comment 9

[Jan Varga [:janv]]

Hi Ryan, filed bug 1608449.

Comment 10

[Ryan VanderMeulen [:RyanVM]]

Thanks!