1606826 - Browsertime android visual metrics job failing to get application name

Status: RESOLVED FIXED

(Testing :: Raptor, defect, P1)

Description

[Robert Wood [:rwood]]

[task 2020-01-03T11:47:09.856Z] 2020-01-03T11:47:09.856764Z Command succeeded result=b'{"SpeedIndex": 0, "FirstVisualChange": 0, "LastVisualChange": 0, "ContentfulSpeedIndex": 0, "videoRecordingStart": 0, "PerceptualSpeedIndex": 0, "VisualProgress": "0=100", "VisuallyComplete": 0}\n'
[task 2020-01-03T11:47:09.861Z] 2020-01-03T11:47:09.861343Z Unhandled exception: 'int' object is not subscriptable
[task 2020-01-03T11:47:09.861Z] Traceback (most recent call last):
[task 2020-01-03T11:47:09.862Z] File "/builds/worker/bin/run-visual-metrics.py", line 514, in <module>
[task 2020-01-03T11:47:09.862Z] sys.exit(main(log, args))
[task 2020-01-03T11:47:09.862Z] File "/builds/worker/bin/run-visual-metrics.py", line 281, in main
[task 2020-01-03T11:47:09.862Z] append_result(log, suites, job.test_name, app_json["application"]["name"],
[task 2020-01-03T11:47:09.862Z] TypeError: 'int' object is not subscriptable

Comment 1

[Robert Wood [:rwood]]

Ah, on browsertime android, in the application.json, there is no version:

{"application": {"version": null, "name": "geckoview"}}

Which is causing the schema verification to fail:

2020-01-03T11:46:48.970059Z Loaded json from file path=PosixPath('/builds/worker/fetches/browsertime-results/application.json') read_json={'application': {'version': None, 'name': 'geckoview'}}
2020-01-03T11:46:48.970386Z Failed to parse json: expected str for dictionary value @ data['application']['version']

Comment 2

[Robert Wood [:rwood]]

Attachment: Bug 1606826 - Browsertime android visual metrics job failing to get application name

Comment 3

[Robert Wood [:rwood]]

https://treeherder.mozilla.org/#/jobs?repo=try&tier=1%2C2%2C3&revision=b15a7312cf2253255ed90e4afa9e9126964de8b4

Comment 4

[Robert Wood [:rwood]]

https://treeherder.mozilla.org/#/jobs?repo=try&tier=1%2C2%2C3&revision=0f422c15a172ba51fa6295e6a817cd76c19403d7

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/de596d0f84d6
Browsertime android visual metrics job failing to get application name r=perftest-reviewers,stephendonner

Comment 6

[Arthur Iakab [arthur_iakab]]

https://hg.mozilla.org/mozilla-central/rev/de596d0f84d6