1606828 - Add -v[v] shorthand flag to ./mach puppeteer-test

Status: RESOLVED FIXED

(Remote Protocol :: Agent, enhancement, P1)

Description

[Andreas Tolfsen ❲:ato❳]

./mach marionette-test has a -v[v] flag to increase Gecko logging verbosity, and it would be convenient to have the same for the remote agent.

Comment 1

[Andreas Tolfsen ❲:ato❳]

(My not-so-secret plan is for logs to stdout to go away with time in favour of a log streaming service as part of the protocol, and it would make sense to capture this with a flag rather than having to remember the specifics of remote.log.level.)

Comment 2

[Andreas Tolfsen ❲:ato❳]

Attachment: bug 1606828: remote: add -v[v] flag to "./mach puppeteer-test"

This introduces a -v[v] flag to the "./mach puppeteer-test" command
for increasing the logging verbosity of the remote agent in Gecko.
This can be used as a shorthand for --setpref="remote.log.level=<level>".

A single -v will enable log messages up to debug level, and two
-vv will enable all log messages up to trace level.

Comment 3

[Andreas Tolfsen ❲:ato❳]

This patch needs the extraPrefsFirefox fix from https://phabricator.services.mozilla.com/D58511.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/24f9ca7b6c8b
remote: add -v[v] flag to "./mach puppeteer-test" r=remote-protocol-reviewers,whimboo

Comment 5

[Andreea Pavel [:apavel]]

https://hg.mozilla.org/mozilla-central/rev/24f9ca7b6c8b