1606937 - Add a FENNEC_BETA define for Fennec Beta builds

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: General, enhancement, P1)

Description

[Stefan Arentz | :st3fan | ⏰ EST | he/him]

This bug is similar to bug 1547710 - we need a FENNEC_BETA define for Fennec Beta builds.

This is a dependency for bug 1601729 (Leanplum Open URL deeplink is unpredictable when multiple versions of Firefox are installed) - which is critical and highly urgent for our Fennec to Fenix migration.

Bug 1547710 has a pretty straightforward patch - I hope we can do the same for this new define.

Comment 1

[Ryan VanderMeulen [:RyanVM]]

This should be pretty straightforward using bug 1547710 as a starting point. However, Johan did refactor things a bit in bug 1562632 to simplify our mozconfig usage. Those changes will need to be taken into account when working on this bug.

Basically, instead of setting |export FENNEC_BETA=1| in all the relevant mozconfigs like the original patch did with FENNEC_NIGHTLY, you'll want to be setting it in the env section in android.yml for the appropriate Beta builds as shown in the push below:
https://hg.mozilla.org/releases/mozilla-esr68/rev/a9ec5cfb029f#l31.12

Beyond that, I don't see any particular gotchas lurking.

Comment 2

[Ryan VanderMeulen [:RyanVM]]

One other follow-up change which landed after bug 1547710:
https://hg.mozilla.org/mozilla-central/diff/35a3b93b21cf7337d313ce00d73583818268f93c/toolkit/modules/AppConstants.jsm

Comment 3

[Petru-Mugurel Lingurar [:petru]]

Attachment: Bug 1606937 - Add FENNEC_BETA define for local/CI beta builds; r?RyanVM,jlorenzo

No more beta mozconfigs means we just need to make sure taskcluster knows to
add the right environment variable for beta builds,
And the Python configure also knows to handle this new variable.

Comment 4

[Petru-Mugurel Lingurar [:petru]]

Attachment: Bug 1606937 - Expose the new FENNEC_BETA env var to AppConstants; r?VladBaicu

Currently unused but might be useful in the future.
Also helps to inform Fennec devs about the existence of this new env var.

Depends on D58959

Comment 5

[Petru-Mugurel Lingurar [:petru]]

Comment on attachment 9119123 [details]
Bug 1606937 - Add FENNEC_BETA define for local/CI beta builds; r?RyanVM,jlorenzo

ESR Uplift Approval Request

• If this is not a sec:{high,crit} bug, please state case for ESR consideration: Patches needed for a high priority ticket - bug 1601729
• User impact if declined:
• Fix Landed on Version:
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Small change.
• String or UUID changes made by this patch:

Comment 6

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 9119123 [details]
Bug 1606937 - Add FENNEC_BETA define for local/CI beta builds; r?RyanVM,jlorenzo

Makes it possible to target code to Fennec Beta builds similar to what we have for Nightly. Approved for 68.5b3.

Comment 7

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-esr68/rev/e8e9b0c94c39
https://hg.mozilla.org/releases/mozilla-esr68/rev/2473f6eab15c

Comment 8

[Petru-Mugurel Lingurar [:petru]]

Because the QA team asked about, in order to test this, one can look in the config.status file
of a beta try build containing this patches and verify if it contains the new FENNEC_BETA define.
A nightly try build would not contain this.
My try nightly / beta try builds containing this patches - https://treeherder.mozilla.org/#/jobs?repo=try&revision=a925274c504b3cc6e4d17ed861700855a64f2b94

This patches though would indirectly be tested when testing bug 1601729.

Comment 9

[Laurentiu Apahidean]

I have downloaded the config.status from the try build provided at comment 8 and can confirm that "FENNEC_BETA=1" is present in the file

Comment 10

[Diana Rus]

Hi, checked the config.status file and confirm that "FENNEC_BETA=1" is present in the file mentioned in comment9:

• Fennec 68.5b4 build 2
• Fennec 68.5b5 build 1
• Fennec 68.5b6 build 1
• Fennec 68.6b1 build 2
  I will mark the ticket as verified.