Closed Bug 1606940 Opened 6 years ago Closed 6 years ago

[wpt-sync] Sync PR 21035 - Assert that empty title is null, rather than empty string

Categories

(Core :: DOM: CSS Object Model, task, P4)

Product:
Core
Component:
DOM: CSS Object Model
Type:
task

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla74
Tracking Flags:
Tracking Status
firefox74 --- fixed

People

(Reporter: wpt-sync, Unassigned)

References

(
URL
)

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 21035 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/21035
Details from upstream follow.

nordzilla <nordzilla@mozilla.com> wrote:

Assert that empty title is null, rather than empty string

See #21033 for more details.

This PR modifies the WPT for Constructable StyleSheets to assert that empty titles return null, rather than the empty string, as noted in the CSSOM spec (here).

Component: web-platform-tests → DOM: CSS Object Model
Product: Testing → Core

CI Results

Ran 9 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 40 tests

Status Summary

Firefox

OK : 1
PASS: 39
FAIL: 24

Chrome

OK : 1
PASS: 23
FAIL: 1

Safari

OK : 1
FAIL: 24

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

/css/cssom/CSSStyleSheet-constructable.html
Constructed stylesheet can be used and modified in multiple TreeScopes: FAIL (Chrome: PASS, Safari: FAIL)
Adding non-constructed stylesheet to AdoptedStyleSheets is not allowed when the owner document of the stylesheet and the AdoptedStyleSheets are in different document trees: FAIL (Chrome: PASS, Safari: FAIL)
Stylesheets constructed on the main Document cannot be used in iframes: FAIL (Chrome: PASS, Safari: FAIL)
CSSStyleSheet.replace produces Promise<CSSStyleSheet>: FAIL (Chrome: PASS, Safari: FAIL)
CSSStyleSheet.replaceSync replaces stylesheet text synchronously: FAIL (Chrome: PASS, Safari: FAIL)
Forcing a style update after adding an adopted stylesheet on a disconnected shadow root should not crash.: FAIL (Chrome: PASS, Safari: FAIL)
Cloning a shadow host will not clone shadow root, and also adoptedStyleSheets: FAIL (Chrome: PASS, Safari: FAIL)
CSSStyleSheet.replace allows import rule inside: FAIL (Chrome: PASS, Safari: FAIL)
new CSSStyleSheet produces empty CSSStyleSheet: FAIL (Chrome: FAIL, Safari: FAIL)
Re-attaching shadow host with adopted stylesheets work: FAIL (Chrome: PASS, Safari: FAIL)
Modifying an adopted stylesheet on a disconnected shadow root should not crash.: FAIL (Chrome: PASS, Safari: FAIL)
Constructed style sheets can be applied on shadow root: FAIL (Chrome: PASS, Safari: FAIL)
Changes to constructed stylesheets through CSSOM is reflected: FAIL (Chrome: PASS, Safari: FAIL)
Attaching a shadow root that already has adopted stylesheets work: FAIL (Chrome: PASS, Safari: FAIL)
Inserting an @import rule through insertRule on a constructed stylesheet throws an exception: FAIL (Chrome: PASS, Safari: FAIL)
CSSStyleSheet.replaceSync throws exception when there is import rule inside: FAIL (Chrome: PASS, Safari: FAIL)
Adding non-constructed stylesheet to AdoptedStyleSheets is not allowed when the owner document of the stylesheet is in the same document tree as the AdoptedStyleSheets: FAIL (Chrome: PASS, Safari: FAIL)
Importing a shadow host will not copy shadow root, and also adoptedStyleSheets: FAIL (Chrome: PASS, Safari: FAIL)
Adopting a shadow host will empty adoptedStyleSheets if adopting to a different document: FAIL (Chrome: PASS, Safari: FAIL)
document.adoptedStyleSheets should initially have length 0.: FAIL (Chrome: PASS, Safari: FAIL)
Constructed style sheets can be applied on document: FAIL (Chrome: PASS, Safari: FAIL)
CSSStyleSheet.replace returns rejected promise on failed imports: FAIL (Chrome: PASS, Safari: FAIL)
Re-attaching shadow host and updating attributes work: FAIL (Chrome: PASS, Safari: FAIL)
Stylesheet constructed on iframe cannot be used in the main Document: FAIL (Chrome: PASS, Safari: FAIL)

CI Results

Ran 9 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 40 tests

Status Summary

Firefox

OK : 1
PASS: 39
FAIL: 24

Chrome

OK : 1
PASS: 23
FAIL: 1

Safari

OK : 1
FAIL: 24

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

/css/cssom/CSSStyleSheet-constructable.html
Constructed stylesheet can be used and modified in multiple TreeScopes: FAIL (Chrome: PASS, Safari: FAIL)
Adding non-constructed stylesheet to AdoptedStyleSheets is not allowed when the owner document of the stylesheet and the AdoptedStyleSheets are in different document trees: FAIL (Chrome: PASS, Safari: FAIL)
Stylesheets constructed on the main Document cannot be used in iframes: FAIL (Chrome: PASS, Safari: FAIL)
CSSStyleSheet.replace produces Promise<CSSStyleSheet>: FAIL (Chrome: PASS, Safari: FAIL)
CSSStyleSheet.replaceSync replaces stylesheet text synchronously: FAIL (Chrome: PASS, Safari: FAIL)
Forcing a style update after adding an adopted stylesheet on a disconnected shadow root should not crash.: FAIL (Chrome: PASS, Safari: FAIL)
Cloning a shadow host will not clone shadow root, and also adoptedStyleSheets: FAIL (Chrome: PASS, Safari: FAIL)
CSSStyleSheet.replace allows import rule inside: FAIL (Chrome: PASS, Safari: FAIL)
new CSSStyleSheet produces empty CSSStyleSheet: FAIL (Chrome: FAIL, Safari: FAIL)
Re-attaching shadow host with adopted stylesheets work: FAIL (Chrome: PASS, Safari: FAIL)
Modifying an adopted stylesheet on a disconnected shadow root should not crash.: FAIL (Chrome: PASS, Safari: FAIL)
Constructed style sheets can be applied on shadow root: FAIL (Chrome: PASS, Safari: FAIL)
Changes to constructed stylesheets through CSSOM is reflected: FAIL (Chrome: PASS, Safari: FAIL)
Attaching a shadow root that already has adopted stylesheets work: FAIL (Chrome: PASS, Safari: FAIL)
Inserting an @import rule through insertRule on a constructed stylesheet throws an exception: FAIL (Chrome: PASS, Safari: FAIL)
CSSStyleSheet.replaceSync throws exception when there is import rule inside: FAIL (Chrome: PASS, Safari: FAIL)
Adding non-constructed stylesheet to AdoptedStyleSheets is not allowed when the owner document of the stylesheet is in the same document tree as the AdoptedStyleSheets: FAIL (Chrome: PASS, Safari: FAIL)
Importing a shadow host will not copy shadow root, and also adoptedStyleSheets: FAIL (Chrome: PASS, Safari: FAIL)
Adopting a shadow host will empty adoptedStyleSheets if adopting to a different document: FAIL (Chrome: PASS, Safari: FAIL)
document.adoptedStyleSheets should initially have length 0.: FAIL (Chrome: PASS, Safari: FAIL)
Constructed style sheets can be applied on document: FAIL (Chrome: PASS, Safari: FAIL)
CSSStyleSheet.replace returns rejected promise on failed imports: FAIL (Chrome: PASS, Safari: FAIL)
Re-attaching shadow host and updating attributes work: FAIL (Chrome: PASS, Safari: FAIL)
Stylesheet constructed on iframe cannot be used in the main Document: FAIL (Chrome: PASS, Safari: FAIL)

Pushed by wptsync@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/ecd44be8488c [wpt PR 21035] - Constructable StyleSheets: Assert that empty title is null, rather than empty string, a=testonly https://hg.mozilla.org/integration/autoland/rev/3390cc8dd5d2 [wpt PR 21035] - Update wpt metadata, a=testonly

https://hg.mozilla.org/mozilla-central/rev/ecd44be8488c
https://hg.mozilla.org/mozilla-central/rev/3390cc8dd5d2

Status: NEW → RESOLVED
Closed: 6 years ago
status-firefox74: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla74
You need to log in before you can comment on or make changes to this bug.