1606962 - Remove mozilla::EnableIf

Status: RESOLVED FIXED

(Core :: MFBT, task)

Description

[Emilio Cobos Álvarez (:emilio)]

We use mozilla::EnableIf and std::enable_if somewhat inconsistently. Is there any reason we can't just remove mozilla::EnableIf and use the std version?

Comment 1

[Jeff Walden [:Waldo]]

No real reason. There might be mild aesthetic interest in transitioning away from TypeTraits.h entirely all at once, but it's probably a foolish consistency to do anything more than half-heartedly aspire to that.

Also I never remember if our STL requirements let us use std::enable_if_t yet or not, but that would likely be preferable if it works. I think one of that and stuff like std::integral_constant_v<...> is usable right now, but I couldn't possibly say which without researching it.

Comment 2

[André Bargull [:anba]]

Attachment: Bug 1606962: Replace mozilla::EnableIf with std::enable_if. r=froydnj!

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/cf661f4a8c95
Replace mozilla::EnableIf with std::enable_if. r=froydnj,jgilbert

Comment 4

[Razvan Maries]

https://hg.mozilla.org/mozilla-central/rev/cf661f4a8c95