1606997 - Let CSS text-underline-position property ride the train to release

Status: RESOLVED FIXED

(Core :: CSS Parsing and Computation, enhancement, P3)

Description

[Jonathan Kew [:jfkthame]]

This has been on Nightly for a month and AFAIK hasn't caused any issues; we should flip the pref to let it go to release.

Comment 1

[Jonathan Kew [:jfkthame]]

Attachment: Bug 1606997 - Let text-underline-position ride the train. r=emilio

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/d91c8bb29d19
Let text-underline-position ride the train. r=emilio

Comment 3

[Bill Goldstein [:aja] (UTC-6)]

Just noticed this checked in on autoland, so thought I'd mention this issue I just stumbled upon:
Seems that with text-underline-position:under the text-underline-offset:auto Underline Offset Origin (Zero Position) is incorrectly relative to alphabetic baseline rather than the text-under edge...will file a bug shortly.
Don't know whether it should block riding the train.

Comment 4

[Jonathan Kew [:jfkthame]]

Hmm, that's a rather wider issue.... looks like the spec has just (last week!) been significantly edited such that we now need to update values of not just text-underline-position but also text-underline-offset to match the latest text in https://drafts.csswg.org/css-text-decor-4.

We should also look at what other browsers have implemented and see where things really stand.

In any case, filing a bug would be good - thanks!

Comment 5

[Bill Goldstein [:aja] (UTC-6)]

Filed: Bug 1607308 "wrong text-underline-offset zero position with text-underline-position:under".

Comment 6

[Bill Goldstein [:aja] (UTC-6)]

text-underline-offset shows as invalid property in Chromium's inspector. No clue about webkit.

Comment 7

[Noemi Erli[:noemi_erli]]

https://hg.mozilla.org/mozilla-central/rev/d91c8bb29d19

Comment 8

[Ryan VanderMeulen [:RyanVM]]

Is this something you wanted to nominate for Fx73 consideration?

Comment 9

[Jonathan Kew [:jfkthame]]

I was originally intending to, but... there have just been some edits to the CSS text-decoration spec, with the result that we need to tweak our implementation a bit (bug 1607308, bug 1607534). I think we should get those adjustments done before shipping this to release, so I'm not eager to uplift this for now. I expect we'll be able to resolve those for Fx74, but I don't think we should uplift this to Fx73 without them.

(If we run into issues in those bugs, I'd probably prefer to revert this patch and hold back the feature for now, rather than shipping the feature according to the older spec and then immediately modifying it in the next cycle.)