1607003 - recent changesets from central cannot be pushed to Try due to one of them referencing a non-public bug from a different repository (request for SKIP_BMO_CHECK)

Status: RESOLVED FIXED

(Developer Services :: Mercurial: hg.mozilla.org, defect)

Description

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

At the moment, Try pushes based on the tip of mozilla-central get rejected by the server:

remote: ************************************ ERROR ************************************
remote: Your commit message references bugs that are currently private. To avoid
remote: disclosing the nature of these bugs publicly, please remove the affected bug ID
remote: from the commit message.
remote:
remote:     Affected bug: 1513586
remote:
remote: Visit https://wiki.mozilla.org/Security/Bug_Approval_Process for more
remote: information.
remote:
remote:
remote: To push this commit anyway and ignore this warning, include SKIP_BMO_CHECK
remote: in your commit message.

Bug 1513586 is about a push to the nss repository: https://hg.mozilla.org/projects/nss/rev/993717228da05c6bf468ac861f01b6849a94eae3

It's referenced in the commit message of https://hg.mozilla.org/mozilla-central/rev/4de1557c27c6a6fc1b0b92dc3fdb507dd9015e50

That blocks pushes based on the tip of mozilla-central and everything pushed later while the push hook is active. The hook got added in bug 1420510.

Tweaking the repository history with setting the problematic changeset's state to draft and then amending the commit message allows one to push to Try but doesn't solve the issue in general.

Comment 1

[Kendall Libby [:fubar] (he/him)]

I've disabled the hook temporarily (next deploy will reset). It's only configured for Try.

Comment 2

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

Verified that Try pushes based on central tip are getting accepted now, thanks to Kendall.

Comment 3

[Connor Sheehan [:sheehan]]

Attachment: ansible/hg-ssh: turn off security bug check hook (Bug 1607003) r?zeid

This hook is currently off as it is erroneously blocking pushes
that should not be blocked. Updating the repo to reflect the current
state, so a later deploy doesn't accidentally turn the hook on before
we are ready to re-enable.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/hgcustom/version-control-tools/rev/102106f53cb2
ansible/hg-ssh: turn off security bug check hook r=zeid