Include build ID in recordings and introduction message
Categories
(Core Graveyard :: Web Replay, enhancement)
Tracking
(firefox73 fixed)
| Tracking | Status | |
|---|---|---|
| firefox73 | --- | fixed |
People
(Reporter: bhackett1024, Assigned: bhackett1024)
References
Details
Attachments
(1 file)
Right now, replay cloud servers are configured with a single set of firefox binaries from a single build. If a replay attempt is made with a recording made on a different build, the cloud replaying process will crash (the build mismatch is detected early in startup). A major goal of cloud replaying is to make it easy to replay any recording, regardless of the build used to generate it. A big part of this is making sure the cloud server can find the right binaries to replay a given recording. The attached patch does this by adding a build ID concept, a string that incorporates the platform name and the ID baked into the binary (mozilla::PlatformBuildID()), something like "macOS-20200104162819". When recording, the build ID is stored in the recording itself, and when spawning a replaying process the middleman reads this build ID and stores it in the introduction message it first sends to the remote connection. The cloud server extracts the build ID from the introduction message and starts the replaying process with the right set of binaries.
|
Assignee | |
Comment 1•4 years ago
|
||
Pushed by bhackett@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/3ac650724604 Include build ID in recordings and introduction message, r=jlast.
|
||
Comment 3•4 years ago
|
||
| bugherder | ||
|
||
Comment 4•4 years ago
|
||
== Change summary for alert #24715 (as of Sat, 18 Jan 2020 18:43:23 GMT) ==
Improvements:
14% sccache hit rate android-5-0-x86_64 asan 0.88 -> 1.00
For up to date results, see: https://treeherder.mozilla.org/perf.html#/alerts?id=24715
|
||
Updated•4 years ago
|
Description
•