1607109 - Upgrade searchfox indexer to LLVM 9/clang 9

Status: RESOLVED FIXED

(Webtools :: Searchfox, task)

Description

[Andrew Sutherland [:asuth] (he/him)]

Bug 1573211 updated mozilla-central to use clang 9 as of Firefox 71. I suggest we upgrade the indexer provisioning to match and because LLVM 9 includes a streaming JSON output API introduced in https://reviews.llvm.org/D60804.

Note that this change will have no impact on what happens on the various taskcluster indexing jobs. That's all controlled by https://searchfox.org/mozilla-central/source/taskcluster/ci/searchfox/kind.yml which defines which toolchain to use which reference the toolchain definitions at https://searchfox.org/mozilla-central/source/taskcluster/ci/toolchain/clang.yml. For example, the linux64-searchfox/debug task currently specifies linux64-clang which is explicitly a toolchain-alias of linux64-clang-9, and the alias gets moved with each clang upgrade, so searchfox is always using the current clang (for the tree it runs in).

Relatedly, this will potentially limit our ability to uplift changes to the in-tree MozsearchIndexer.cpp for ESR68. But since 71 is already in release, there wouldn't be any problems for beta/release.

Comment 1

[Andrew Sutherland [:asuth] (he/him)]

Attachment: GitHub Pull Request

Comment 2

[Andrew Sutherland [:asuth] (he/him)]

(Meant to land this over the past weekend, but I'm cleaning up tabs.)

Comment 3

[Andrew Sutherland [:asuth] (he/him)]

I neglected to re-provision the indexer when I landed this change in comment 2. I'm going to re-provision now and then immediately trigger a "fancy" build that should test the provisioning.