1607204 - Invalid command line in compile_commands.json

Status: RESOLVED FIXED

(Firefox Build System :: General, defect, P3)

Description

[Calixte Denizet (:calixte)]

In compile_commands.json, I get:

{
"directory": "/home/calixte/dev/mozilla/mozilla-central.hg/obj-x86_64-pc-linux-gnu/netwerk/srtp/src", 
"command": "... '-DPACKAGE_STRING=\"libsrtp2' '2.2.0-pre\"' '-DPACKAGE_VERSION=\"2.2.0-pre\"' ...", 
"file": "/home/calixte/dev/mozilla/mozilla-central.hg/obj-x86_64-pc-linux-gnu/netwerk/srtp/src/Unified_c_netwerk_srtp_src0.c"
}

I think this is incorrect and it should be '-DPACKAGE_STRING=\"libsrtp2 2.2.0-pre\"'.
This option is defined here:
https://searchfox.org/mozilla-central/source/netwerk/srtp/src/moz.build#40
And for any reason, the argument is splitted around space.

Comment 1

[Calixte Denizet (:calixte)]

The guilty line is:
https://searchfox.org/mozilla-central/source/python/mozbuild/mozbuild/compilation/database.py#105

Comment 2

[Ricky Stewart]

Attachment: Bug 1607204 - Invalid command line in compile_commands.json

Comment 3

[Ricky Stewart]

Attachment: Bug 1607204 - Fix invalid command line in compile_commands.json

Comment 4

[Ricky Stewart]

Attachment: diff compile_command.json

See the attached diff in compile_commands.json with my patch. I think this looks right?

Comment 5

[Ricky Stewart]

Attachment: diff compile_command.json

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/25964226853a
Invalid command line in compile_commands.json r=froydnj

Comment 7

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/25964226853a

Comment 8

[Stefan Hindli [:stefan_hindli]]

Backed out changeset 25964226853a (Bug 1607204) for causing Bug 1610471 which crashes the reviewbot a=backout CLOSED TREE

https://treeherder.mozilla.org/#/jobs?repo=mozilla-central&resultStatus=testfailed%2Cbusted%2Cexception&classifiedState=unclassified&revision=6e625f8c4c1852a56ce4a7db8f16c6b8b8da3d23

Comment 9

[Ricky Stewart]

Attachment: diff compile_command.json

Comment 10

[Sylvestre Ledru [:Sylvestre]]

Would it be possible to have a unit test on this too?
thanks

Comment 12

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/84891824f497
Fix invalid command line in compile_commands.json r=froydnj

Comment 13

[Bogdan Tara[:bogdan_tara | bogdant]]

https://hg.mozilla.org/mozilla-central/rev/84891824f497