160732 - A task and an event should not be selected at the same time

Status: RESOLVED WONTFIX

(Calendar :: Sunbird Only, defect)

Description

[alge]

it should only be possible to have one selected task/event at one time.. so if
you have a selected event and select a task, it should un-select the event. then
the edit-button on the toolbar could be used for both events and tasks (whatever
is selected)

right now the edit-button is ambigious if you have both a task and an event
selected - "edit what?" - same with delete.

Comment 1

[alge]

Attachment: clears selection on event-listbox when selection something in todo-tree and vice versa

My first couple of js lines ever. (=

btw - when you select a todo item now, the delete button on the toolbar goes
enabled - disabled. is it supposed to do that?

Comment 2

[alge]

humm, the delete button is slightly flawed, btw. should probably open a new bug
for making delete and edit buttons work better.

the delete button calls unifinderDeleteCommand in unifinder.js, which first
checks whether unifinderToDoFocus has focus .. that's imho bad design, the
delete and edit buttons should be implemented outside unifinder[ToDo], and they
should check which of the {unifinder, unifinderToDo} has selected members, and
delete / edit the selected thingie. just my idea. (=

Comment 3

[ajbu]

Hi, I am not sure deleting the selection is the best solution, you might use 
focus+selection to detect what should be deleted. I already changed the css so 
only in the list that has focus the selection is highlighted to make that 
visible.

> the delete button calls unifinderDeleteCommand in unifinder.js, which first
> checks whether unifinderToDoFocus has focus .. that's imho bad design
It is indeed bad design, I wrote it myself a few days ago ;-) It's only a hack 
so events don't get deleted by mistake when in the tasklist.
The problem is that the taskslist was only added recently, and all the code 
(copy/paste/delete/edit/import/export...) assumes there are only events.

To do it all right, there has to be a (rather large) redesign to integrate 
events and tasks, currently a lot is in unifinder.js, like the 
enabling/disabling of the toolbar buttons.

Big question (For mike?) is, do we just hack to make it work now, and plan a 
big reconstructon when al features are in, or first refactor?

Comment 4

[alge]

yep .. looks like EventSelection should be changed into a more generic Selection
thingie that handles both events and tasks.

Comment 5

[alge]

Attachment: clears selection in EventSelection / todo-tree. delete button works.

delete button now works, and all changes are marked with "TODO HACK".

Comment 6

[Mike Potter]

Is this fixed in the latest builds?

Comment 7

[ajbu]

with the latest builds you can *focus* only one list at the same time, color 
of selection indicates where the focus is.
Commands should only work on the items that are selected _and_ focused, I see 
no reason for removing the selection for the un-focused list.

Note that only delete checks for focus && selected.
So I guess this is fixed, another bug is that copy, edit.. only work on 
events, not tasks

Comment 8

[alge]

hmm, look at http://alge.nlc.no/~alge/cal.png
with the gtk+-theme I'm using (mozilla-modern-2), it's hard to see which is
focused, the task-tree or the event box. maybe killing the selection is slightly
dramatic, what about just making the focused-box-thing more obvious? (like an
inner border or something)

Comment 9

[ajbu]

I agree, maybe change the colors, should Calendar use the same (modern) colors 
as elsewhere for selection/focus? Now selections in Calendar are (almost) the 
same color as non-focused items elsewhere (menu, mail/news, sidebar...)

Comment 10

[alge]

I think the modern/mailnews selectioncolors are nice.

Comment 11

[ajbu]

I'll patch the css so colors will match the theme, I moved that to bug 163858, 
closing this.

Comment 12

[Reed Loden [:reed]]

The bugspam monkeys have been set free and are feeding on Calendar :: Sunbird Only. Be afraid for your sanity!