Closed Bug 1607344 Opened 7 months ago Closed 7 months ago

we run linux64-stylo-seq(sy) and linux64(sy), are these needed anymore?

Categories

(Testing :: AWSY, task, P1)

Version 3
task

Tracking

(firefox74 fixed)

RESOLVED FIXED
mozilla74
Tracking Status
firefox74 --- fixed

People

(Reporter: jmaher, Assigned: stephend)

References

Details

(Whiteboard: [ci-costs-2020:done])

Attachments

(1 file)

we have had the stylo-seq(sy) jobs for a long time, my understanding is we wanted to compare non stylo with stylo...before we shipped stylo by default a long time ago. is there a request in the last 6+ months indicating a need to keep running this?

similarly, we have awsy and awsy-tp6, do we need both jobs, or can we just have awsy-tp6?

:davehunt, can you provide references for the duplication or remove it?

Flags: needinfo?(dave.hunt)

Stephen is going to pick this up. We should consider any tests (not just AWSY) where we're deviating from default stylo configuration.

Assignee: nobody → stephen.donner
Status: NEW → ASSIGNED
Flags: needinfo?(dave.hunt)
Flags: needinfo?(stephen.donner)

Push to try, here: https://treeherder.mozilla.org/#/jobs?repo=try&tier=1%2C2%2C3&revision=0135ecd6a76c0f65b4e51ddf33d00c967c8c1612

re: other test suites, I think the remaining removal needed is for Tss, Tss-fis, Tss-1proc, here: https://searchfox.org/mozilla-central/rev/ba4fab1cc2f1c9c4e07cdb71542b8d441707c577/taskcluster/ci/config.yml#79-81 (which seem to all be automagically transform-created); I'll file a bug for that work separately, tomorrow.

Flags: needinfo?(stephen.donner)
Priority: -- → P1

(In reply to Stephen Donner [:stephend] from comment #4)

Push to try, here: https://treeherder.mozilla.org/#/jobs?repo=try&tier=1%2C2%2C3&revision=0135ecd6a76c0f65b4e51ddf33d00c967c8c1612

re: other test suites, I think the remaining removal needed is for Tss, Tss-fis, Tss-1proc, here: https://searchfox.org/mozilla-central/rev/ba4fab1cc2f1c9c4e07cdb71542b8d441707c577/taskcluster/ci/config.yml#79-81 (which seem to all be automagically transform-created); I'll file a bug for that work separately, tomorrow.

What about the following?

'Tsd': 'Talos performance tests, Stylo disabled'
'Tsd-1proc': 'Talos performance tests with Stylo disabled without e10s'
'SYsd': 'Are we slim yet tests by TaskCluster, Stylo disabled'

oh, the stylo disabled tests, good find- I would be surprised if we need them.

(In reply to Dave Hunt [:davehunt] [he/him] ⌚BST from comment #5)

(In reply to Stephen Donner [:stephend] from comment #4)
<snip>

What about the following?

'Tsd': 'Talos performance tests, Stylo disabled'
'Tsd-1proc': 'Talos performance tests with Stylo disabled without e10s'
'SYsd': 'Are we slim yet tests by TaskCluster, Stylo disabled'

Ah yes, thanks; I had considered those and keyed on Stylo "sequential" in my head, rather than "deviating from default Stylo configuration," which these clearly seem to be. I'll try to take care of all these Talos cleanup in an upcoming new bug/PR.

Pushed by sdonner@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/05f81cc8b39c
Fix Bug 1607344; remove legacy stylo-seq linux64 jobs. r=erahm,jmaher

Backed out changeset 05f81cc8b39c (Bug 1607344) for causing multiple failures at builds/worker/workspace/mozharness/mozharness/base/script.py

Push with failure: https://treeherder.mozilla.org/#/jobs?repo=autoland&group_state=expanded&resultStatus=testfailed%2Cbusted%2Cexception&classifiedState=unclassified&revision=05f81cc8b39c6e7d12727e29e3df5df2e310bc34

Failure log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=284479984&repo=autoland&lineNumber=1374

[task 2020-01-10T23:28:35.518Z] 23:28:35     INFO -  INFO - File linux64-minidump_stackwalk retrieved from local cache /builds/worker/tooltool-cache
[task 2020-01-10T23:28:35.571Z] 23:28:35     INFO - Return code: 0
[task 2020-01-10T23:28:35.572Z] 23:28:35     INFO - Chmoding /builds/worker/workspace/build/linux64-minidump_stackwalk to 0755
[task 2020-01-10T23:28:35.572Z] 23:28:35     INFO - Running post-action listener: _package_coverage_data
[task 2020-01-10T23:28:35.572Z] 23:28:35     INFO - Running post-action listener: _resource_record_post_action
[task 2020-01-10T23:28:35.573Z] 23:28:35     INFO - Running post-action listener: process_java_coverage_data
[task 2020-01-10T23:28:35.573Z] 23:28:35     INFO - [mozharness: 2020-01-10 23:28:35.572798Z] Finished run-tests step (failed)
[task 2020-01-10T23:28:35.574Z] 23:28:35    FATAL - Uncaught exception: Traceback (most recent call last):
[task 2020-01-10T23:28:35.575Z] 23:28:35    FATAL -   File "/builds/worker/workspace/mozharness/mozharness/base/script.py", line 2132, in run
[task 2020-01-10T23:28:35.575Z] 23:28:35    FATAL -     self.run_action(action)
[task 2020-01-10T23:28:35.575Z] 23:28:35    FATAL -   File "/builds/worker/workspace/mozharness/mozharness/base/script.py", line 2071, in run_action
[task 2020-01-10T23:28:35.576Z] 23:28:35    FATAL -     self._possibly_run_method(method_name, error_if_missing=True)
[task 2020-01-10T23:28:35.576Z] 23:28:35    FATAL -   File "/builds/worker/workspace/mozharness/mozharness/base/script.py", line 2026, in _possibly_run_method
[task 2020-01-10T23:28:35.576Z] 23:28:35    FATAL -     return getattr(self, method_name)()
[task 2020-01-10T23:28:35.576Z] 23:28:35    FATAL -   File "/builds/worker/workspace/mozharness/scripts/desktop_unittest.py", line 793, in run_tests
[task 2020-01-10T23:28:35.576Z] 23:28:35    FATAL -     if not self._run_category_suites(category):
[task 2020-01-10T23:28:35.577Z] 23:28:35    FATAL -   File "/builds/worker/workspace/mozharness/scripts/desktop_unittest.py", line 886, in _run_category_suites
[task 2020-01-10T23:28:35.577Z] 23:28:35    FATAL -     if self.config['single_stylo_traversal']:
[task 2020-01-10T23:28:35.578Z] 23:28:35    FATAL - KeyError: 'single_stylo_traversal'
[task 2020-01-10T23:28:35.578Z] 23:28:35    FATAL - Running post_fatal callback...
[task 2020-01-10T23:28:35.578Z] 23:28:35    FATAL - Exiting -1
[task 2020-01-10T23:28:35.579Z] 23:28:35     INFO - Running post-run listener: _resource_record_post_run
[task 2020-01-10T23:28:35.631Z] 23:28:35     INFO - Validating Perfherder data against /builds/worker/workspace/mozharness/external_tools/performance-artifact-schema.json
[task 2020-01-10T23:28:35.635Z] 23:28:35     INFO - PERFHERDER_DATA: {"framework": {"name": "job_resource_usage"}, "suites": [{"subtests": [{"name": "cpu_percent", "value": 50.25}, {"name": "io_write_bytes", "value": 36864}, {"name": "io.read_bytes", "value": 0}, {"name": "io_write_time", "value": 16}, {"name": "io_read_time", "value": 0}], "extraOptions": ["e10s", "taskcluster-m5.large"], "name": "mochitest.mochitest-browser-chrome.3.overall"}, {"subtests": [{"name": "time", "value": 0.031010866165161133}], "name": "mochitest.mochitest-browser-chrome.3.start-pulseaudio"}, {"subtests": [{"name": "time", "value": 11.747267007827759}, {"name": "cpu_percent", "value": 50.1}], "name": "mochitest.mochitest-browser-chrome.3.install"}, {"subtests": [{"name": "time", "value": 0.0007300376892089844}], "name": "mochitest.mochitest-browser-chrome.3.stage-files"}, {"subtests": [{"name": "time", "value": 0.14529705047607422}], "name": "mochitest.mochitest-browser-chrome.3.run-tests"}]}
[task 2020-01-10T23:28:35.635Z] 23:28:35     INFO - Total resource usage - Wall time: 11s; CPU: Can't collect data; Read bytes: 0; Write bytes: 36864; Read time: 0; Write time: 16
[task 2020-01-10T23:28:35.635Z] 23:28:35     INFO - TinderboxPrint: I/O read bytes / time<br/>0 / 0
[task 2020-01-10T23:28:35.635Z] 23:28:35     INFO - TinderboxPrint: I/O write bytes / time<br/>36,864 / 16
[task 2020-01-10T23:28:35.635Z] 23:28:35     INFO - TinderboxPrint: CPU idle<br/>10.9 (49.7%)
[task 2020-01-10T23:28:35.635Z] 23:28:35     INFO - TinderboxPrint: CPU system<br/>0.3 (1.5%)
[task 2020-01-10T23:28:35.635Z] 23:28:35     INFO - TinderboxPrint: CPU user<br/>10.8 (48.9%)
[task 2020-01-10T23:28:35.636Z] 23:28:35     INFO - TinderboxPrint: Swap in / out<br/>0 / 0
[task 2020-01-10T23:28:35.636Z] 23:28:35     INFO - start-pulseaudio - Wall time: 0s; CPU: Can't collect data; Read bytes: 0; Write bytes: 0; Read time: 0; Write time: 0
[task 2020-01-10T23:28:35.636Z] 23:28:35     INFO - install - Wall time: 12s; CPU: 50.0%; Read bytes: 0; Write bytes: 36864; Read time: 0; Write time: 16
[task 2020-01-10T23:28:35.636Z] 23:28:35     INFO - stage-files - Wall time: 0s; CPU: Can't collect data; Read bytes: 0; Write bytes: 0; Read time: 0; Write time: 0
[task 2020-01-10T23:28:35.636Z] 23:28:35     INFO - run-tests - Wall time: 0s; CPU: Can't collect data; Read bytes: 0; Write bytes: 0; Read time: 0; Write time: 0
Backout by dvarga@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/011b7846466d
Backed out changeset 05f81cc8b39c for causing multiple failures at builds/worker/workspace/mozharness/mozharness/base/script.py

(In reply to Pulsebot from comment #11)

Backout by dvarga@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/011b7846466d
Backed out changeset 05f81cc8b39c for causing multiple failures at
builds/worker/workspace/mozharness/mozharness/base/script.py

Wow; sorry - I missed desktop_unittest; my codebase grepping is lousy, I guess. Will fix ASAP.

Pushed by sdonner@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/fd1001cea260
Fix Bug 1607344; remove legacy stylo-seq linux64 jobs. r=erahm,jmaher

(In reply to Pulsebot from comment #13)

Pushed by sdonner@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/fd1001cea260
Fix Bug 1607344; remove legacy stylo-seq linux64 jobs. r=erahm,jmaher

For which the completed, passing try push was (sorry for not referencing it earlier): https://treeherder.mozilla.org/#/jobs?repo=try&tier=1%2C2%2C3&revision=b8b9a62fdd23891e92ab41aba6b5ba58f32ff8ba. Here's trusting we stick this landing.

Backed out changeset fd1001cea260 for causing wpt failures regarding single_stylo_traversal.

Backout link: https://hg.mozilla.org/integration/autoland/rev/ac04f5112cb8f60dbb09b5820648e7a2a76d4517

Push with failures: https://treeherder.mozilla.org/#/jobs?repo=autoland&resultStatus=testfailed%2Cbusted%2Cexception%2Crunnable&tochange=ac04f5112cb8f60dbb09b5820648e7a2a76d4517&fromchange=34b855ac76ea37bc1dc02d6437194991e85b64e3&selectedJob=284515332

Failure log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=284515332&repo=autoland&lineNumber=1002

[task 2020-01-11T07:51:58.741Z] 07:51:58 INFO - [mozharness: 2020-01-11 07:51:58.741742Z] Finished run-tests step (failed)
[task 2020-01-11T07:51:58.742Z] 07:51:58 FATAL - Uncaught exception: Traceback (most recent call last):
[task 2020-01-11T07:51:58.742Z] 07:51:58 FATAL - File "/builds/worker/workspace/mozharness/mozharness/base/script.py", line 2132, in run
[task 2020-01-11T07:51:58.743Z] 07:51:58 FATAL - self.run_action(action)
[task 2020-01-11T07:51:58.743Z] 07:51:58 FATAL - File "/builds/worker/workspace/mozharness/mozharness/base/script.py", line 2071, in run_action
[task 2020-01-11T07:51:58.743Z] 07:51:58 FATAL - self._possibly_run_method(method_name, error_if_missing=True)
[task 2020-01-11T07:51:58.743Z] 07:51:58 FATAL - File "/builds/worker/workspace/mozharness/mozharness/base/script.py", line 2026, in _possibly_run_method
[task 2020-01-11T07:51:58.743Z] 07:51:58 FATAL - return getattr(self, method_name)()
[task 2020-01-11T07:51:58.743Z] 07:51:58 FATAL - File "/builds/worker/workspace/mozharness/scripts/web_platform_tests.py", line 362, in run_tests
[task 2020-01-11T07:51:58.743Z] 07:51:58 FATAL - if self.config['single_stylo_traversal']:
[task 2020-01-11T07:51:58.743Z] 07:51:58 FATAL - KeyError: 'single_stylo_traversal'
[task 2020-01-11T07:51:58.743Z] 07:51:58 FATAL - Running post_fatal callback...
[task 2020-01-11T07:51:58.743Z] 07:51:58 FATAL - Exiting -1

Flags: needinfo?(stephen.donner)

Really. Sorry.

I won't push again without:

  1. full understanding of the set of tests in try I need to run successfully, passing, before pushing (after review)
  2. re-reviews, with the above

That said, I'll keep grepping for occurrences and fix and push to Phab, until I do, obviously.

Hi Marco! Eric suggested you might be able to help me diagnose/figure out what to do with the linux-64-ccov crashes seen in this try push: https://treeherder.mozilla.org/#/jobs?repo=try&tier=1%2C2%2C3&author=sdonner%40mozilla.com&selectedJob=284749173. Any ideas or suggestions? Thanks!

Flags: needinfo?(stephen.donner) → needinfo?(mcastelluccio)

Don't worry about them, they are pre-existing (bug 1607584 and bug 1607587) and not due to your patch.

Flags: needinfo?(mcastelluccio)

(In reply to Marco Castelluccio [:marco] from comment #18)

Don't worry about them, they are pre-existing (bug 1607584 and bug 1607587) and not due to your patch.

Thanks! New try push here: https://treeherder.mozilla.org/#/jobs?repo=try&tier=1%2C2%2C3&revision=ff95bba4aa9e5eafd7d6cac8b3523ad4db0f47ac.

Note that the retriggers of the intermittent wpt* jobs are passing (but I'm still cautious).

Pushed by sdonner@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/f9a25b1dc0c5
Fix Bug 1607344; remove legacy stylo-seq linux64 jobs. r=erahm,jmaher
Status: ASSIGNED → RESOLVED
Closed: 7 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla74
Whiteboard: [ci-costs-2020:done]
You need to log in before you can comment on or make changes to this bug.