1607498 - about dialog's restart to update button does not get re-added if the restart is cancelled by the user (e.g. via onbeforeunload dialogs)

Status: RESOLVED FIXED

(Toolkit :: Application Update, defect, P3)

Description

[ptrpl4]

Attachment: Screenshot 2020-01-07 at 19.23.36.png

User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:71.0) Gecko/20100101 Firefox/71.0

Steps to reproduce:

1. you need 1 tab with "closing checking"
   (if you didn't save last changes and click "close tab" or "update browser" - browser show alert "close tab or not") my example - https://app.gitbook.com
2. start update process from "about window:
3. you will see alert from tab from point 1
4. click in alert window "i don't want restart browser now"

Actual results:

browser still working - its ok
but i cant start again restart process from "about" window
i see infinity waiting for restart (screenshot)

Expected results:

i want to see restart button on "about" page again
and have ability to start process again

Comment 1

[Timea Cernea [:tbabos][inactive]]

Hi ptrpl4,
Unfortunately, I don't have a GitBook account to use the mentioned example.
Could you specify how did you manage to trigger the about window while the "Exit and close tabs?" window is displayed? [step 2]
On Windows 10, other interactions with the browser UI is not possible while that window is toggled, I will check this out on MacOS too tomorrow but maybe you can clarify that in the meantime.

Comment 2

[ptrpl4]

Attachment: Screen Recording 2020-01-13 at 13.22.56.mov

Comment 3

[Timea Cernea [:tbabos][inactive]]

Seems that it is specific to the dialogs created by pages. Is this reproducible without any addons installed?
Moving this over to a component in the meantime.

Comment 4

[ptrpl4]

i found!
you can reproduce it on any page on wikipedia.org

1. open any article
2. click edit
3. do some changes (do not save changes!)
4. open "about" and click update
5. you will see alert from page - close alert
6. open about window again

p.s.
already checked it on windows

Comment 5

[Timea Cernea [:tbabos][inactive]]

Hmm, grab the about window when it is stuck in that "Restarting..." loop and move it down. You will see that the "Leave this Page" prompt from wikipedia is actually displayed behind it.
If you choose to "Leave this page" Firefox will update and restart.

Is this also happening in your case?

Comment 6

[ptrpl4]

yes. i know, if i choose "leave" page option - browser will update and its ok

my point - if i choose another option and want to "stay" on page, then i will see infinite "restarting" on "about" page. This looks not right.
I think right logic - i will see "restart and update browser" button again

Comment 7

[BugBot [:suhaib / :marco/ :calixte]]

The priority flag is not set for this bug.
:Dolske, could you have a look please?

For more information, please visit auto_nag documentation.

Comment 8

[Molly Howell (she/her) (no longer active)]

Reproducible for me using the STR from comment 4 (thank you for providing an easy test case!).

Comment 10

[Mark Banner (:standard8)]

Attachment: Bug 1607498 - If an update via the about dialog is cancelled due to staying on a page, ensure the dialog is reset to the apply state. r?bytesized

Comment 11

[Phabricator Automation]

Comment on attachment 9277351 [details]
Bug 1607498 - If an update via the about dialog is cancelled due to staying on a page, ensure the dialog is reset to the apply state. r?bytesized

Revision D146805 was moved to bug 1739977. Setting attachment 9277351 [details] to obsolete.

Comment 12

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/c1c3545f1e49
If an update via the about dialog is cancelled due to staying on a page, ensure the dialog is reset to the apply state. r=application-update-reviewers,bytesized

Comment 13

[Norisz Fay [:noriszfay]]

https://hg.mozilla.org/mozilla-central/rev/c1c3545f1e49