16075 - API: nsIAccountManager::CreateIncomingServer doesn't set server type

Status: VERIFIED FIXED

(SeaMonkey :: MailNews: Account Configuration, defect, P1)

Description

[tonyr]

Create a new incoming server with CreateIncomingServer( "imap", &myServer);
Create an account with nsIAccountManager::CreateAccount()
Call account->SetIncomingServer( myServer);

The data saved into prefs.js after this executes does not include the type for
the newly created server - the name, hostname, and userName are present but
mail.server.serverX.type is missing.

This wreaks havoc later on and causes the new account and server to be non-
functional and to crash portions of the UI.

Comment 1

[Alec Flett]

Woah! This explains a couple wierd bugs...this is great!
I've got the fix ready in my tree, just need a review.

Comment 2

[Alec Flett]

fix checked in.

Comment 3

[Ninoschka Baca]

To test this should I create a new account and check the preferences to verify
that the "type" entry is correct?

Comment 4

[Alec Flett]

I think tonyr or suresh should verify this with some JavaScript
Tony or Suresh?

Comment 5

[Suresh]

Alec, just want to make sure couple of things before I mark this bug as
Verified.
1. Where is the method 'SetIncomingServer'?
2. I have used 'CreateIncomingServer(...)' to create a new account. And the type
shows up in prefs.js file. Is this enough to verify this bug or should I use
'SetIncomingServer()' method?

Comment 6

[Alec Flett]

oh, in C++, attributes get changed into Get/Set methods
so the "incomingServer" attribute becomes GetIncomingServer and
SetIncomingServer

So anyway, "incomingServer" is ok.
What we need to verify is that when I say createIncomingServer(type), that the
server.type value is actually set to the type given.

Comment 7

[Alec Flett]

thanks for the help, BTW :)

Comment 8

[Suresh]

Changing QA Contact. Verified by testing all three types (pop, imap, nntp).

Comment 9

[Pulsebot]

Pushed by ffxbld-merge:
https://hg.mozilla.org/releases/mozilla-beta/rev/5751d50db089
[fenix] Closes https://github.com/mozilla-mobile/fenix/issues/16075: Add distribution_id in telemetry startup metrics (https://github.com/mozilla-mobile/fenix/pull/16821)