Closed Bug 1607522 Opened 7 months ago Closed 5 months ago

./mach browsertime --setup still shows some python packages are missing

Categories

(Testing :: Performance, defect, P1)

Version 3
Desktop
Linux
defect

Tracking

(firefox74 fixed, firefox75 fixed, firefox76 fixed)

RESOLVED FIXED
mozilla76
Tracking Status
firefox74 --- fixed
firefox75 --- fixed
firefox76 --- fixed

People

(Reporter: sefeng, Assigned: tarek)

References

(Blocks 1 open bug)

Details

Attachments

(2 files)

➜  mozilla-central ./mach browsertime --setup --clobber
 0:00.31 Using artifact from local cache: /home/sefeng/.mozbuild/cache/browsertime/a560bb8c17bb72cc-ffmpeg-4.1.4-i686-static.tar.xz
 0:00.31 Unpacking temporary location /home/sefeng/.mozbuild/cache/browsertime/a560bb8c17bb72cc-ffmpeg-4.1.4-i686-static.tar.xz
 0:01.74 Installing browsertime node module from /home/sefeng/mozilla/mozilla-central/tools/browsertime/package.json
Clobbering /home/sefeng/mozilla/mozilla-central/tools/browsertime/node_modules...
Installing browsertime for mach using "/usr/bin/nodejs /home/sefeng/.mozbuild/node/bin/npm ci --loglevel=error"...
info sharp Using cached /home/sefeng/.npm/_libvips/libvips-8.7.4-linux-x64.tar.gz

browsertime installed successfully!

NOTE: Your local browsertime binary is at /home/sefeng/mozilla/mozilla-central/tools/browsertime/node_modules/.bin/browsertime

 0:13.22 /home/sefeng/mozilla/build/obj-sccache/_virtualenvs/init/bin/python /home/sefeng/mozilla/mozilla-central/tools/browsertime/node_modules/browsertime/vendor/visualmetrics.py --check
ffmpeg:   OK
convert:  OK
compare:  OK
Pillow:   FAIL
SSIM:     FAIL
OS: Unspecified → Linux
Hardware: Unspecified → Desktop
Assignee: nobody → tarek

I see that _activate_virtualenv() calls results are not checked.

Nick, any reason not to fail when _activate_virtualenv() returns False?

Flags: needinfo?(nalexander)

answered in a meeting : we should check that result and fail

Flags: needinfo?(nalexander)

Sean, can you try the following:

./mach bootstrap --no-system-changes
./mach browsertime --setup --clobber

works for me on Windows 10 and current mozilla-central

Flags: needinfo?(sefeng)

Let's stop if the packages could not be installed.
Also, let's skip the call if we find them.

Still the same error :(

Flags: needinfo?(sefeng)
Pushed by tziade@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/08999096f418
hard stop if Pillow or pyssim could not be installed r=nalexander
Status: NEW → RESOLVED
Closed: 7 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla74

So...this is still an issue for me. https://paste.mozilla.org/9LsA1f3K#L23

Adding import sys; raise Exception(sys.executable) before https://searchfox.org/mozilla-central/source/tools/browsertime/mach_commands.py#414 raises Exception: /usr/bin/python2.7 , which is the problem because it's not the python executable of the virtual env.

Status: RESOLVED → REOPENED
Resolution: FIXED → ---

When a package is installed with "pip --user", the import
works right after the virtualenv activation.
Even if we force its install via mozbuild virtualenv
it will fail. This patch checks if the installed package is inside or
outside the virtualenv. If it's outside, it forces
its installation inside.

Notice that we might want to mvoe that logic in mozbuild/virtualenv.py

Priority: -- → P1
Pushed by tziade@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/d8b9fdbd8762
improve dependency detection r=sefeng,perftest-reviewers,sparky
Status: REOPENED → RESOLVED
Closed: 7 months ago5 months ago
Resolution: --- → FIXED
Target Milestone: mozilla74 → mozilla76

Change the status for beta to have the same as nightly and release.
For more information, please visit auto_nag documentation.

You need to log in before you can comment on or make changes to this bug.