Closed Bug 1607540 Opened 4 years ago Closed 4 years ago

[wpt-sync] Sync PR 21074 - CacheStorage: Set opaque mode for code cache.

Categories

(Core :: DOM: Service Workers, task, P4)

Product:
Core
Component:
DOM: Service Workers
Type:
task

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla74
Tracking Flags:
Tracking Status
firefox74 --- fixed

People

(Reporter: mozilla.org, Unassigned)

References

(
URL
)

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 21074 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/21074
Details from upstream follow.

Ben Kelly <wanderview@chromium.org> wrote:

CacheStorage: Set opaque mode for code cache.

This CL restores code to set the V8 code cache generation opaque mode
based on the response tainting. It was previously incorrectly removed
in crrev.com/c/1828726.

This CL adds a test that verifies scripts loaded from cache_storage are
treated as opaque when appropriate.

Note, the test does not actually provoke the issue in crbug.com/1037701
but it still provides missing test coverage so it seems good to land.

The CL also fixes an incorrect DCHECK that the test triggers. The
assumption in the DCHECK was incorrect and should instead be a runtime
check.

Bug: 1037701
Change-Id: I894b30ad9dac6c3a47e1b5f325ee7906768b57f3

Reviewed-on: https://chromium-review.googlesource.com/1988675
WPT-Export-Revision: d0ed6f264d55c4094f07b2f9942447d02b89746a

Component: web-platform-tests → DOM: Service Workers
Product: Testing → Core

CI Results

Ran 13 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 40 tests

Status Summary

Firefox

OK : 1
PASS: 2[['GitHub']] 41[[u'Gecko-android-em-7.0-x86_64-debug-geckoview', u'Gecko-android-em-7.0-x86_64-opt-geckoview', u'Gecko-linux64-asan-opt', u'Gecko-linux64-debug', u'Gecko-linux64-opt', u'Gecko-linux64-qr-debug', u'Gecko-linux64-qr-opt', u'Gecko-windows10-64-debug', u'Gecko-windows10-64-opt', u'Gecko-windows10-64-qr-debug', u'Gecko-windows10-64-qr-opt', u'Gecko-windows7-32-debug', u'Gecko-windows7-32-opt']]
FAIL: 2

Chrome

OK : 1
PASS: 3
FAIL: 1

Safari

OK : 1
PASS: 4

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

Firefox-only Failures

/service-workers/service-worker/opaque-script.https.html
Verify large cross-origin cache_storage scripts are opaque.: FAIL
Verify small cross-origin cache_storage scripts are opaque.: FAIL

New Tests That Don't Pass

/service-workers/service-worker/opaque-script.https.html
Verify large cross-origin cache_storage scripts are opaque.: FAIL (Chrome: PASS, Safari: PASS)
Verify small cross-origin cache_storage scripts are opaque.: FAIL (Chrome: PASS, Safari: PASS)

CI Results

Ran 13 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 40 tests

Status Summary

Firefox

OK : 1
PASS: 2[['GitHub']] 41[[u'Gecko-android-em-7.0-x86_64-debug-geckoview', u'Gecko-android-em-7.0-x86_64-opt-geckoview', u'Gecko-linux64-asan-opt', u'Gecko-linux64-debug', u'Gecko-linux64-opt', u'Gecko-linux64-qr-debug', u'Gecko-linux64-qr-opt', u'Gecko-windows10-64-debug', u'Gecko-windows10-64-opt', u'Gecko-windows10-64-qr-debug', u'Gecko-windows10-64-qr-opt', u'Gecko-windows7-32-debug', u'Gecko-windows7-32-opt']]
FAIL: 2

Chrome

OK : 1
PASS: 3
FAIL: 1

Safari

OK : 1
PASS: 4

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

Firefox-only Failures

/service-workers/service-worker/opaque-script.https.html
Verify large cross-origin cache_storage scripts are opaque.: FAIL
Verify small cross-origin cache_storage scripts are opaque.: FAIL

New Tests That Don't Pass

/service-workers/service-worker/opaque-script.https.html
Verify large cross-origin cache_storage scripts are opaque.: FAIL (Chrome: PASS, Safari: PASS)
Verify small cross-origin cache_storage scripts are opaque.: FAIL (Chrome: PASS, Safari: PASS)

Pushed by wptsync@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/6c2b94786d66
[wpt PR 21074] - CacheStorage: Set opaque mode for code cache., a=testonly
https://hg.mozilla.org/integration/autoland/rev/17a7b3909c3e
[wpt PR 21074] - Update wpt metadata, a=testonly

https://hg.mozilla.org/mozilla-central/rev/6c2b94786d66
https://hg.mozilla.org/mozilla-central/rev/17a7b3909c3e

Status: NEW → RESOLVED
Closed: 4 years ago
status-firefox74: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla74
You need to log in before you can comment on or make changes to this bug.