Closed Bug 1607545 Opened 10 months ago Closed 8 months ago

about_home_topsites_first_paint scalar is recorded on first about:home sighting even if it wasn't the first page loaded

Categories

(Firefox :: New Tab Page, defect)

defect
Not set
normal

Tracking

()

VERIFIED FIXED
Firefox 75
Tracking Status
firefox75 --- verified

People

(Reporter: mconley, Assigned: mconley)

References

(Blocks 1 open bug)

Details

(Whiteboard: [fxperf:p1])

Attachments

(1 file, 1 obsolete file)

STR:

  1. Ensure Firefox is configured to load about:home by default, and not to restore the previous session.
  2. Launch Firefox Nightly via ./mach with ./mach run https://www.mozilla.org.
  3. Once the initial tab finishes loading, open a new tab, and browse to about:telemetry
  4. Choose "Scalars" along the left-hand side, and note that the about_home_topsites_first_paint scalar is (correctly) absent.
  5. Open a new window.
  6. Reload about:telemetry

ER:

The about_home_topsites_first_paint scalar should still be missing.

AR:

The about_home_topsites_first_paint was recorded.

This might account for some of the truly egregious measurements we're getting on the about_home_topsites_first_paint probe, which is supposed to measure the time between process start and rendering the initial about:home.

Blocks: 1610558

Hey k88hudson, if there's someone more appropriate to review this, or you're bogged down, let me know and I'll redirect. Thanks!

Flags: needinfo?(khudson)
Pushed by mconley@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/cfb9cc9ee352
Don't record about_home_topsites_first_paint scalar unless the first windows initial tab is about:home. r=k88hudson
Backout by opoprus@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/c7218dc33989
Backed out changeset cfb9cc9ee352 for node failures on a CLOSED TREE

Backed out changeset cfb9cc9ee352 (bug 1607545) for node failures

Push that started the failures: https://treeherder.mozilla.org/#/jobs?repo=autoland&resultStatus=superseded%2Ctestfailed%2Cbusted%2Cexception%2Crunnable&revision=cfb9cc9ee352674f247aef75c73de318994fc308&selectedJob=286426056

Failure log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=286426056&repo=autoland&lineNumber=273

Backout: https://hg.mozilla.org/integration/autoland/rev/c7218dc33989b88f360c0340080661121fa7cb95

[task 2020-01-24T22:54:06.508Z] TEST-UNEXPECTED-FAIL karma | activity-stream:TelemetryFeed:#saveSessionPerfData should call maybeRecordTopsitesPainted when url is about:home and topsites_first_painted_ts is given: AboutNewTabStartupRecorder is not defined
[task 2020-01-24T22:54:06.508Z] saveSessionPerfData@http://localhost:9876/base/test/unit/unit-entry.js?e6e7df87a2ee16648a18118dc3af3e07cb701552:150742:77205
[task 2020-01-24T22:54:06.508Z] @http://localhost:9876/base/test/unit/unit-entry.js?e6e7df87a2ee16648a18118dc3af3e07cb701552:150140:16
[task 2020-01-24T22:54:06.508Z]
[task 2020-01-24T22:54:06.508Z] TEST START | sasslint
[task 2020-01-24T22:54:08.020Z] { karmaPassed: false, sasslintPassed: true }
[task 2020-01-24T22:54:08.020Z] CODE 1
[fetches 2020-01-24T22:54:08.023Z] removing /builds/worker/fetches
[fetches 2020-01-24T22:54:08.057Z] finished
[taskcluster 2020-01-24 22:54:08.389Z] === Task Finished ===
[taskcluster 2020-01-24 22:54:08.389Z] Unsuccessful task run with exit code: 1 completed in 268.196 seconds

Flags: needinfo?(mconley)
Attachment #9123931 - Attachment is obsolete: true
Pushed by mconley@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/7be6903300cf
Don't record about_home_topsites_first_paint scalar unless the first windows initial tab is about:home. r=k88hudson

Oh ha ha. I see now why it was a separate phabricator revision with the original getting backed out. Sorry for the delays!

Flags: needinfo?(mconley)
Flags: needinfo?(khudson)
Status: NEW → RESOLVED
Closed: 8 months ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 75

I have verified that this issue is no longer reproducible with the latest Firefox Nightly (75.0a1 Build ID - 20200212093201) installed, on Windows 10 x64, Ubuntu 18.04 x64 and Mac 10.15.2. Now, I can confirm that after following the steps from the description the about_home_topsites_first_paint scalar is not displayed on the "about:telemetry" page.

Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.