1607545 - about_home_topsites_first_paint scalar is recorded on first about:home sighting even if it wasn't the first page loaded

Status: VERIFIED FIXED

(Firefox :: New Tab Page, defect)

Description

[Mike Conley (:mconley) (:⚙️)]

STR:

0. Ensure Firefox is configured to load about:home by default, and not to restore the previous session.
1. Launch Firefox Nightly via ./mach with ./mach run https://www.mozilla.org.
2. Once the initial tab finishes loading, open a new tab, and browse to about:telemetry
3. Choose "Scalars" along the left-hand side, and note that the about_home_topsites_first_paint scalar is (correctly) absent.
4. Open a new window.
5. Reload about:telemetry

ER:

The about_home_topsites_first_paint scalar should still be missing.

AR:

The about_home_topsites_first_paint was recorded.

This might account for some of the truly egregious measurements we're getting on the about_home_topsites_first_paint probe, which is supposed to measure the time between process start and rendering the initial about:home.

Comment 1

[Mike Conley (:mconley) (:⚙️)]

Attachment: Bug 1607545 - Don't record about_home_topsites_first_paint scalar unless the first windows initial tab is about:home. r?k88hudson

Comment 2

[Mike Conley (:mconley) (:⚙️)]

Hey k88hudson, if there's someone more appropriate to review this, or you're bogged down, let me know and I'll redirect. Thanks!

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/cfb9cc9ee352
Don't record about_home_topsites_first_paint scalar unless the first windows initial tab is about:home. r=k88hudson

Comment 4

[Pulsebot]

Backout by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/c7218dc33989
Backed out changeset cfb9cc9ee352 for node failures on a CLOSED TREE

Comment 5

[Oana Pop-Rus]

Backed out changeset cfb9cc9ee352 (bug 1607545) for node failures

Push that started the failures: https://treeherder.mozilla.org/#/jobs?repo=autoland&resultStatus=superseded%2Ctestfailed%2Cbusted%2Cexception%2Crunnable&revision=cfb9cc9ee352674f247aef75c73de318994fc308&selectedJob=286426056

Failure log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=286426056&repo=autoland&lineNumber=273

Backout: https://hg.mozilla.org/integration/autoland/rev/c7218dc33989b88f360c0340080661121fa7cb95

[task 2020-01-24T22:54:06.508Z] TEST-UNEXPECTED-FAIL karma | activity-stream:TelemetryFeed:#saveSessionPerfData should call maybeRecordTopsitesPainted when url is about:home and topsites_first_painted_ts is given: AboutNewTabStartupRecorder is not defined
[task 2020-01-24T22:54:06.508Z] saveSessionPerfData@http://localhost:9876/base/test/unit/unit-entry.js?e6e7df87a2ee16648a18118dc3af3e07cb701552:150742:77205
[task 2020-01-24T22:54:06.508Z] @http://localhost:9876/base/test/unit/unit-entry.js?e6e7df87a2ee16648a18118dc3af3e07cb701552:150140:16
[task 2020-01-24T22:54:06.508Z]
[task 2020-01-24T22:54:06.508Z] TEST START | sasslint
[task 2020-01-24T22:54:08.020Z] { karmaPassed: false, sasslintPassed: true }
[task 2020-01-24T22:54:08.020Z] CODE 1
[fetches 2020-01-24T22:54:08.023Z] removing /builds/worker/fetches
[fetches 2020-01-24T22:54:08.057Z] finished
[taskcluster 2020-01-24 22:54:08.389Z] === Task Finished ===
[taskcluster 2020-01-24 22:54:08.389Z] Unsuccessful task run with exit code: 1 completed in 268.196 seconds

Comment 6

[Mike Conley (:mconley) (:⚙️)]

Attachment: Bug 1607545 - Update TelemetryFeed.test.js for new mechanism for recording the time to paint the topsites region at startup. r?k88hudson

Depends on D60416

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/7be6903300cf
Don't record about_home_topsites_first_paint scalar unless the first windows initial tab is about:home. r=k88hudson

Comment 8

[Ed Lee :Mardak]

Oh ha ha. I see now why it was a separate phabricator revision with the original getting backed out. Sorry for the delays!

Comment 9

[Razvan Maries]

https://hg.mozilla.org/mozilla-central/rev/7be6903300cf

Comment 10

[Marius Coman [:mcoman], Ecosystem QA]

I have verified that this issue is no longer reproducible with the latest Firefox Nightly (75.0a1 Build ID - 20200212093201) installed, on Windows 10 x64, Ubuntu 18.04 x64 and Mac 10.15.2. Now, I can confirm that after following the steps from the description the about_home_topsites_first_paint scalar is not displayed on the "about:telemetry" page.