1607622 - [wpt-sync] Sync PR 21077 - Fix for corner case without quotes in multi parameter

Status: RESOLVED FIXED

(Core :: Audio/Video: Playback, task, P4)

Description

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Sync web-platform-tests PR 21077 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/21077
Details from upstream follow.

Dongheun Kang <[e-mail]> wrote:

Fix for corner case without quotes in multi parameter

Run MediaSource.isTypeSupported('audio/webm;codecs=vorbis;test="6"'),
it return false. This is because the value of codecs is parsed as '6"'.
Fix for the above problem.

Bug: None
Change-Id: I8ddd97e1d53be84b095d9dcdd487cef24000d86c

Reviewed-on: https://chromium-review.googlesource.com/1989298
WPT-Export-Revision: c8d6b0193a561f2cde204454ca55f607d0e4894f

Comment 1

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=6364296ef41d7133a970e97b2d3ccb6dd93d9d71

Comment 2

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

CI Results

Ran 13 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 45 tests

Status Summary

Firefox

OK : 1
PASS: 40[GitHub] 84[Gecko-android-em-7.0-x86_64-debug-geckoview, Gecko-android-em-7.0-x86_64-opt-geckoview, Gecko-linux1804-64-asan-opt, Gecko-linux1804-64-debug, Gecko-linux1804-64-opt, Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-qr-opt, Gecko-windows10-64-debug, Gecko-windows10-64-opt, Gecko-windows10-64-qr-debug, Gecko-windows10-64-qr-opt, Gecko-windows7-32-debug, Gecko-windows7-32-opt]
FAIL: 7

Chrome

OK : 1
PASS: 45
FAIL: 2

Safari

OK : 1
PASS: 35
FAIL: 12

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

Firefox-only Failures

/media-source/mediasource-is-type-supported.html
Test invalid MIME format "video/webm;codecs="": FAIL
Test invalid MIME format "video/webm;codecs=""": FAIL
Test invalid MIME format "video/webm;": FAIL
Test invalid MIME format "video/webm;codecs=": FAIL
Test invalid MIME format "video/webm;codecs": FAIL
Test invalid MIME format "video/webm": FAIL

New Tests That Don't Pass

/media-source/mediasource-is-type-supported.html
Test invalid MIME format "video/webm;codecs="": FAIL (Chrome: PASS, Safari: PASS)
Test invalid MIME format "video/webm;codecs=""": FAIL (Chrome: PASS, Safari: PASS)
Test invalid MIME format "video/webm;": FAIL (Chrome: PASS, Safari: PASS)
Test invalid MIME format "video/webm;codecs=": FAIL (Chrome: PASS, Safari: PASS)
Test invalid MIME format "video/webm;codecs": FAIL (Chrome: PASS, Safari: PASS)
Test invalid MIME format "audio/webm;aaacodecsbbb=opus": FAIL (Chrome: FAIL, Safari: PASS)
Test invalid MIME format "video/webm": FAIL (Chrome: PASS, Safari: PASS)

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/403f6cf397a6
[wpt PR 21077] - Modify ContentType::Parameter() for various cases, a=testonly
https://hg.mozilla.org/integration/autoland/rev/7fc8bbfb641c
[wpt PR 21077] - Update wpt metadata, a=testonly

Comment 4

[Cristina Coroiu [:ccoroiu]]

https://hg.mozilla.org/mozilla-central/rev/403f6cf397a6
https://hg.mozilla.org/mozilla-central/rev/7fc8bbfb641c