1607627 - TB 68 introduced a colour issue for high contrast theme users in the Lightning caledar add-on when creating start/end times for Events.

Status: RESOLVED FIXED

(Calendar :: General, defect)

Description

[BJ]

Attachment: Screen shot

User Agent: Mozilla/5.0 (Windows NT 6.1; Win64; x64; rv:71.0) Gecko/20100101 Firefox/71.0

Steps to reproduce:

Use a Windows theme which give high contrst white text on a black background.
Within lightning create a new Event.
Click on the down arrow to enter a start time.

Actual results:

The background colour of the Minutes pain has not been set correctly. It is different from the background colour of the Hours pane above it.

Expected results:

In previous versions the background colour ofthe Minutes and Hours pane was the same.

Comment 1

[BJ]

Please see Bug 1506094 - v60.0 introduced an accessibility problem with the colors set within the Lightning calendar add-on.

This was a similar problem within the mini-month pane and was resolved in 68. However, 68 introduced tha same problem to the create Events display.

Unlike the previous bug all text remains visible this time so the problem is not critical.

Comment 2

[Richard Marti (:Paenglab)]

Attachment: 1607627-datetimetimepickers-bug15699-CSS-part-port.patch

This is a ESR only issue.

I don't know why and when the anonid was removed in ESR but we need now the CSS part of the patch from bug 1569925 to set the colours. Tested on Windows 10 with a patched Lightning XPI.

Comment 3

[Paul Morris [:pmorris]]

Comment on attachment 9119325 [details] [diff] [review]
1607627-datetimetimepickers-bug15699-CSS-part-port.patch

Review of attachment 9119325 [details] [diff] [review]:
-----------------------------------------------------------------

Changes look good.  Thanks for the fix.

Comment 4

[Richard Marti (:Paenglab)]

Geoff, can you land this to ESR only?

Comment 5

[Geoff Lankow (:darktrojan)]

ESR 68.4.1:
https://hg.mozilla.org/releases/comm-esr68/rev/afc61dccd44560fac1f8647821e55b110e3fe370

Fallen: milestone 68.4.1 needed.