Closed Bug 1607755 Opened 9 months ago Closed 5 months ago

Remove setupInParent approach for BoxModelHighlighter

Categories

(DevTools :: Inspector, task, P1)

task

Tracking

(Fission Milestone:M6, firefox77 fixed)

RESOLVED FIXED
Firefox 77
Fission Milestone M6
Tracking Status
firefox77 --- fixed

People

(Reporter: rcaliman, Assigned: rcaliman)

References

Details

(Whiteboard: dt-fission-m2-mvp)

Attachments

(1 file)

Reverting changes added with bug 1572651 to support Fission because the setupInParent approach will be deprecated.

The replacement of the communication approach will happen in bug 1598307.

Tracking DevTools bugs for Fission Nightly (M6) milestone

Fission Milestone: --- → M6

The changes that are being removed now were introduced as a Fission-compatible approach in Bug 1572651, but were made obsolete by the fact that setupInParent() will not get a Fission-compatible replacement under the hood.

The replacement box model highlighter is implemented in Bug 1598307.

Most of the changes are removed aside from server/actors/highlighters/box-model-renderer.js which is the subset of code from server/actors/highlighters/boxmodel.js that handles only the rendering of the highlighter markup. This is reused in the upcoming replacement (see D54022).

Assignee: nobody → rcaliman
Status: NEW → ASSIGNED
Priority: P2 → P1
Pushed by rcaliman@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/970701512fe9
Remove box model highlighter implementation with setupInParent() r=jdescottes
Status: ASSIGNED → RESOLVED
Closed: 5 months ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 77
You need to log in before you can comment on or make changes to this bug.