Closed Bug 1607756 Opened 4 years ago Closed 4 years ago

Extract node picker functionality from HighlighterActor

Categories

(DevTools :: Inspector, task, P2)

Product:
DevTools
Component:
Inspector
Type:
task

Tracking

(Fission Milestone:M6c, firefox80 fixed)

Status:
RESOLVED FIXED
Milestone:
Firefox 80
Project Flags:
Fission Milestone M6c
Tracking Flags:
Tracking Status
firefox80 --- fixed

People

(Reporter: rcaliman, Assigned: rcaliman)

References

(Blocks 4 open bugs, Regressed 1 open bug)

Details

(Whiteboard: dt-fission-m2-mvp)

Attachments

(1 file, 6 obsolete files)

Bug 1607756 - Extract node picker from HighlighterActor.
47 bytes, text/x-phabricator-request
Details | Review

Disconnect the node picking behavior from node highlighting.

The node picker's job is to attach DOM event listeners in the target document, then emit events when elements are hovered or clicked. It becomes the client's job to react to those events by invoking the element highlighter.

Tracking DevTools bugs for Fission Nightly (M6) milestone

Fission Milestone: --- → M6
See Also: → 1608180
See Also: → 1624287

Depends on D54022

Blocks: 1568827

Tracking dt-fission-m2-mvp bugs for Fission Nightly milestone (M6c)

Fission Milestone: M6 → M6c
Attached file Bug 1607756 - Prototype (obsolete) —

WIP

Attachment #9135097 - Attachment is obsolete: true
Summary: Extract node picker functionality into its own Actor → Extract node picker functionality from HighlighterActor
Attachment #9155561 - Attachment description: Bug 1607756 - Extract node picker from HighlighterActor into its own actor → Bug 1607756 - Extract node picker from HighlighterActor
Attachment #9155561 - Attachment description: Bug 1607756 - Extract node picker from HighlighterActor → Bug 1607756 - Prototype
Assignee: nobody → rcaliman
Status: NEW → ASSIGNED
Attachment #9155561 - Attachment is obsolete: true
Attachment #9156718 - Attachment description: Bug 1607756 - Extract node picker from HighlighterActor → Bug 1607756 - PROTOTYPE
Attachment #9156718 - Attachment description: Bug 1607756 - PROTOTYPE → Bug 1607756 - PROTOTYPE Extract node picker from HighlighterActor, introduce highlighter manager
Attachment #9160064 - Attachment is obsolete: true
Attachment #9160064 - Attachment is obsolete: false
Attachment #9160064 - Attachment is obsolete: true
Blocks: 1646028
No longer depends on: 1598307
Blocks: 1650812
Blocks: 1651033
Attachment #9160062 - Attachment description: Bug 1607756 - (Part 1) Extract node picker from HighlighterActor → Bug 1607756 - Extract node picker from HighlighterActor.

Comment on attachment 9160063 [details]
Bug 1607756 - (Part 2) Add generic highligher management to HighlightersOverlay

Revision D81526 was moved to bug 1646028. Setting attachment 9160063 [details] to obsolete.

Attachment #9160063 - Attachment is obsolete: true

Comment on attachment 9160065 [details]
Bug 1607756 - (Part 3) Update tests for node picker + box model highlighter

Revision D81528 was moved to bug 1646028. Setting attachment 9160065 [details] to obsolete.

Attachment #9160065 - Attachment is obsolete: true
Attachment #9156718 - Attachment is obsolete: true
Pushed by rcaliman@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/cc4b615e1a1a
Extract node picker from HighlighterActor. r=ochameau,devtools-backward-compat-reviewers

https://hg.mozilla.org/mozilla-central/rev/cc4b615e1a1a

Status: ASSIGNED → RESOLVED
Closed: 4 years ago
status-firefox80: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 80
Regressions: 1668265
Regressions: 1740281
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: