1607810 - Drag & drop a link onto Bookmarks menu/Bookmarks widget broken after exiting DOM fullscreen

Status: RESOLVED FIXED

(Firefox :: Bookmarks & History, defect, P2)

Description

[mat.stivic]

User Agent: Mozilla/5.0 (Windows NT 6.1; Win64; x64; rv:72.0) Gecko/20100101 Firefox/72.0

Steps to reproduce:

Firefox 72.0 and 71 bookmarks save problem.

Actual results:

The full screen resets everything as in: https://bugzilla.mozilla.org/show_bug.cgi?id=1601706
As in this case.

Expected results:

Everything works when Firefox restarts. No error except scroll problems.
Until we get into full screen.
Everything is shown in the video.
I tried on 2 computers.

Comment 1

[mat.stivic]

Attachment: Firefox 72.0 And 71 Bookmarks Save Problem.m4v

Comment 2

[Alice0775 White]

[Tracking Requested - why for this release]: Bookmark drag and drop is broken after exit DOM fullscreen

Reproducible: The problem is reproduced after exiting DOM Fullscreen mode more than once.

STR:

1. Open a video file

2. Enter video Fullscreen mode and exit the Fullscreen mode

3. Drag an any link and drag over Bookmarks menu(or Bookmarks widget)
   --- you can see drop indicator when dragover bookmarks popup as expected

4. Again, enter video Fullscreen mode and exit the Fullscreen mode

5. Drag an any link and drag over Bookmarks menu(or Bookmarks widget)
   --- Bug appears.

Actual Results:
No drop indicator is shown.
Sub-folder would not open when drag over it.

Expected Results:
Drop indicator should be shown properly.
Sub-folder should open when drag over it.
And dropped link should be inserted in the correct position

Regression window:
https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=ac5fc1e491a2bb5481d47247bea3c2b22318001c&tochange=517c9efa9592ad0c103ec2542e4bc7fcaf06c505

Comment 3

[Alice0775 White]

Browser console shows an error at step 5 of comment#5

TypeError: can't access property "canMoveNode", this._rootView.controller is null places-menupopup.js:418:11
    on_dragstart chrome://browser/content/places/places-menupopup.js:418
    MozPlacesPopup chrome://browser/content/places/places-menupopup.js:31
    (Async: EventListener.handleEvent)
    MozPlacesPopup chrome://browser/content/places/places-menupopup.js:31
    (Async: CustomElementConstructor)
    <anonymous> chrome://browser/content/places/places-menupopup.js:572
    <anonymous> chrome://browser/content/browser.xhtml:114

Comment 4

[Dão Gottwald [:dao]]

Looks like the places view or the controller don't properly survive CSS frame reconstruction, or aren't properly reinitialized or something like that?

Comment 5

[BugBot [:suhaib / :marco/ :calixte]]

The priority flag is not set for this bug.
:mak, could you have a look please?

For more information, please visit auto_nag documentation.

Comment 6

[Marco Bonardo [:mak]]

We likely need to uninit the view, similarly to what we do for customization in other Places views (_placesView.uninit()).
https://searchfox.org/mozilla-central/rev/cbd110d718bc89a499d3f996af24532abbf6f8ea/browser/base/content/browser-places.js#1539

Comment 7

[Marco Bonardo [:mak]]

We likely need to uninit the view, similarly to what we do for customization in other Places views (_placesView.uninit()).
Do the same steps work after a customization? (I wonder if we're completely missing uninit management for the menubar)

Comment 8

[Alice0775 White]

The patch of Bug 1611689 seems to fix this bug.

Comment 9

[BugBot [:suhaib / :marco/ :calixte]]

Changing the priority to p2 as the bug is tracked by a release manager for the current nightly.
See What Do You Triage for more information

Comment 10

[Alice0775 White]

Reproduced with Nightly74.0a1 (20200128092639) Windows10.
And the issue is verified fixed with Nightly74.0a1 (20200128214036) Windows10.

Fixed by Bug 1611689.

Comment 11

[Rares Doghi, Desktop QA]

This issue is verified as fixed in our latest Nightly build 74.0a1 (2020-01-30) on both Windows 7 as well as Windows 10. I will update the flags accordingly.