Rework partial generation 'platform' key to avoid treeherder use
Categories
(Release Engineering :: Release Automation: Updates, defect)
Tracking
(firefox74 fixed)
| Tracking | Status | |
|---|---|---|
| firefox74 | --- | fixed |
People
(Reporter: sfraser, Assigned: sfraser)
References
Details
Attachments
(3 files)
A stopgap measure to prevent a repeat of Bug 1607382, this uses the build_platform in attributes instead of the treeherder platform, to convert and then examine Balrog.
I think longer term having separate attributes for the different fields would be useful, so that we end up with a platform field containing one of linux, linux64, win32, win64, win64-aarch, macosx64, and other fields contain debug/asan/ccov/reporter/nightly/shippable and other options.
|
Assignee | |
Updated•4 years ago
|
|
|
Assignee | |
Comment 1•4 years ago
|
||
The new code is a superset of the old, so I've left it much the same to avoid conflicts until we come up with a more long term solution.
Pushed by sfraser@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/2df2c4305725 Change platform field used in partials tasks r=mtabara
|
||
Comment 3•4 years ago
|
||
The only thing it used it for was for a default filename, but we
always pass an explicit name, so remove the platform option and the
default filename.
|
|
||
Comment 4•4 years ago
|
||
|
||
Comment 5•4 years ago
|
||
| bugherder | ||
Pushed by mozilla@hocat.ca: https://hg.mozilla.org/integration/autoland/rev/a6d10498ee87 [partials] Don't pass platform to funsize; r=sfraser https://hg.mozilla.org/integration/autoland/rev/ec6201138386 Don't use treeherder platform for partials; r=sfraser
|
||
Comment 7•4 years ago
|
||
Backed out 2 changesets (Bug 1607857) for causing lint failure at /builds/worker/checkouts/gecko/taskcluster/taskgraph/transforms/mar_signing.py
Push with failure:https: //treeherder.mozilla.org/#/jobs?repo=autoland&group_state=expanded&selectedJob=284434472&resultStatus=testfailed%2Cbusted%2Cexception&classifiedState=unclassified&revision=ec620113838689ad5fece3978fbece96a19042a5
Failure log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=284434472&repo=autoland&lineNumber=329
[task 2020-01-10T18:05:18.954Z] 18:05:18.954 flake8 (100) | Command: --config /builds/worker/checkouts/gecko/.flake8 --output-file /tmp/tmpaypozmmx --format {"path":"%(path)s","lineno":%(row)s,"column":%(col)s,"rule":"%(code)s","message":"%(text)s"} --filename *.configure,*.py
[task 2020-01-10T18:05:19.009Z] 18:05:19.8 flake8 (101) | Command: --config /builds/worker/checkouts/gecko/.flake8 --output-file /tmp/tmp6vntfbda --format {"path":"%(path)s","lineno":%(row)s,"column":%(col)s,"rule":"%(code)s","message":"%(text)s"} --filename *.configure,*.py
[task 2020-01-10T18:05:23.477Z] 18:05:23.477 flake8 (98) | Finished in 4.83 seconds
[task 2020-01-10T18:06:11.842Z] 18:06:11.842 flake8 (99) | Finished in 53.19 seconds
[task 2020-01-10T18:06:31.545Z] 18:06:31.544 flake8 (101) | Finished in 72.89 seconds
[task 2020-01-10T18:07:53.532Z] 18:07:53.532 flake8 (100) | Finished in 154.88 seconds
[task 2020-01-10T18:07:53.541Z] TEST-UNEXPECTED-ERROR | /builds/worker/checkouts/gecko/taskcluster/taskgraph/transforms/mar_signing.py:16:1 | 'taskgraph.util.partials.get_balrog_platform_name' imported but unused (F401)
[taskcluster 2020-01-10 18:07:54.079Z] === Task Finished ===
[taskcluster 2020-01-10 18:07:54.427Z] Unsuccessful task run with exit code: 1 completed in 460.563 seconds
Pushed by mozilla@hocat.ca: https://hg.mozilla.org/integration/autoland/rev/422bdca5084a [partials] Don't pass platform to funsize; r=sfraser https://hg.mozilla.org/integration/autoland/rev/b6e5faa0693d Don't use treeherder platform for partials; r=sfraser
|
|
||
Updated•4 years ago
|
|
|
||
Comment 9•4 years ago
|
||
| bugherder | ||
Description
•