1607900 - "Failed to use Conduit API" should be more descriptive

Status: RESOLVED FIXED

(Conduit :: moz-phab, enhancement)

Description

[Mitchell Hentges [:mhentges] 🦀]

For some failures, moz-phab will stop and print the message "Failed to use Conduit API" without other details (even if DEBUG=1 and --trace is provided).

To reproduce

1. Follow the local-dev instructions
2. When you run moz-phab, it will fail with

Failed to use Conduit API

3. If you DEBUG=1 moz-phab --trace, you see:

DEBUG    2020-01-08 20:16:23,105 defaulting to `submit`
DEBUG    2020-01-08 20:16:23,106 found hg repo in /home/phab/test-repo
DEBUG    2020-01-08 20:16:23,106 $ hg --version --quiet
DEBUG    2020-01-08 20:16:23,164 Mercurial Distributed SCM (version 4.6)
DEBUG    2020-01-08 20:16:23,165 $ hg config
DEBUG    2020-01-08 20:16:23,232 $ hg --config extensions.rebase= --pager never --config rebase.experimental.inmemory=true log -T '{node}
' -r 'ancestors(.) and not public() and not obsolete()'
DEBUG    2020-01-08 20:16:23,301 d7cafa5374d396331befa361127d3f0dc7acebad
DEBUG    2020-01-08 20:16:23,301 $ hg --config extensions.rebase= --pager never --config rebase.experimental.inmemory=true log -T '{node}
' -r .
DEBUG    2020-01-08 20:16:23,373 d7cafa5374d396331befa361127d3f0dc7acebad
DEBUG    2020-01-08 20:16:23,373 http://phabricator.test/api/conduit.ping {}
ERROR    2020-01-08 20:16:23,374 Failed to use Conduit API

Unfortunately, this ^ doesn't tell you what the core issue is (in this case, the issue is that local-dev makes requests with http, which moz-phab doesn't like by default).

Suggested improvement

1. moz-phab should provide more actionable feedback when it fails with "Failed to use Conduit API"
2. The local-dev image should have HTTP_ALLOWED set by default

Comment 1

[Piotr Zalewa [:zalun]]

Just realized the same today.

Comment 2

[Piotr Zalewa [:zalun]]

Attachment: Bug 1607900 - log CommandError in Conduit.ping r=mhentges