1607923 - Logpoints do not work for workers

Status: RESOLVED FIXED

(DevTools :: Debugger, defect, P1)

Description

[Jason Laster [:jlast]]

What were you doing?

STR:

1. go to http://dbg-workers.glitch.me/
2. add a logpoint on worker.js:22 in onMessage
3. click the button

ER: see the log in the console
AR: see the error threadActor._parent._consoleActor is undefined

Comment 1

[Jason Laster [:jlast]]

I tried this in an earlier nightly (september 2019) and it did not work. I don't think it ever worked.

Comment 2

[Jason Laster [:jlast]]

diff --git a/devtools/server/startup/worker.js b/devtools/server/startup/worker.js
index b53736d7a1734..055f1d8c100de 100644
--- a/devtools/server/startup/worker.js
+++ b/devtools/server/startup/worker.js
@@ -116,6 +116,7 @@ this.addEventListener("message", function(event) {
       const consoleActor = new WebConsoleActor(connection, parent);
       pool.addActor(consoleActor);
+      parent._consoleActor = consoleActor;

This fixes the first half. The second part is an error with messages.arguments not having a map function. I'm not sure what to do with that.

Comment 3

[Jason Laster [:jlast]]

Attachment: Bug 1607923 - Logpoints do not work for workers. r=bhackett

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/0e538f767312
Logpoints do not work for workers. r=bhackett,nchevobbe

Comment 5

[Dorel Luca [:dluca]]

Backed out changeset 0e538f767312 (bug 1607923) for XPCShell in devtools/server/tests/unit/test_logpoint-01.js. CLOSED TREE

Log:
https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=285137558&repo=autoland&lineNumber=821

Push with failures:
https://treeherder.mozilla.org/#/jobs?repo=autoland&group_state=expanded&revision=0e538f767312b0fff2dfed404e998cf06bbcf755

Backout:
https://hg.mozilla.org/integration/autoland/rev/e69960479b2ad9c896146229645a62da5bf3586f

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/6e34bbd02f6d
Logpoints do not work for workers. r=bhackett,nchevobbe

Comment 7

[Bogdan Tara[:bogdan_tara | bogdant]]

https://hg.mozilla.org/mozilla-central/rev/6e34bbd02f6d