Closed Bug 1607928 Opened 4 years ago Closed 4 years ago

[wpt-sync] Sync PR 21095 - Fix TimingAllowOrigin in ElementTiming and LargestContentfulPaint

Categories

(Core :: Performance, task, P4)

Product:
Core
Component:
Performance
Type:
task

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla74
Tracking Flags:
Tracking Status
firefox74 --- fixed

People

(Reporter: mozilla.org, Unassigned)

References

(
URL
)

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 21095 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/21095
Details from upstream follow.

Nicolás Peña Moreno <npm@chromium.org> wrote:

Fix TimingAllowOrigin in ElementTiming and LargestContentfulPaint

This CL uses the computed timing_allow_passed_ from CORSUrlLoader to
determine the Timing-Allow-Origin checks for the ElementTiming and the
LargestContentfulPaint APIs. This works since OOR-CORS is now enabled
by default.

Bug: 1003943
Change-Id: Id571c5a39b2ef7c7565d3a1560a4b66a03ba7fdd
Reviewed-on: https://chromium-review.googlesource.com/1992590
WPT-Export-Revision: 9b50ecabbfe41aa16b8cc9e32d02029607eb65c7

Component: web-platform-tests → Performance
Product: Testing → Core

CI Results

Ran 10 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 41 tests

Status Summary

Firefox

OK : 2
PASS: 39
FAIL: 2

Chrome

OK : 2
FAIL: 2

Safari

OK : 2
FAIL: 2

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

/largest-contentful-paint/multi-redirects-TAO.html
Cross-origin image without TAO should not have its renderTime set, with full TAO it should.: FAIL (Chrome: FAIL, Safari: FAIL)
/element-timing/multi-redirect-image.html
Cross-origin image without TAO should not have its renderTime set, with full TAO it should.: FAIL (Chrome: FAIL, Safari: FAIL)

Pushed by wptsync@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/2009295c4df3
[wpt PR 21095] - Fix TimingAllowOrigin in ElementTiming and LargestContentfulPaint, a=testonly
https://hg.mozilla.org/integration/autoland/rev/286ce6fa291d
[wpt PR 21095] - Update wpt metadata, a=testonly

https://hg.mozilla.org/mozilla-central/rev/2009295c4df3
https://hg.mozilla.org/mozilla-central/rev/286ce6fa291d

Status: NEW → RESOLVED
Closed: 4 years ago
status-firefox74: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla74
You need to log in before you can comment on or make changes to this bug.