Closed Bug 1607934 Opened 4 years ago Closed 4 years ago

[wpt-sync] Sync PR 21096 - Add test automation for manual native file system tests.

Categories

(Testing :: web-platform-tests, task, P4)

Product:
Testing
Component:
web-platform-tests
Type:
task

Tracking

(firefox74 fixed)

Status:
RESOLVED FIXED
Milestone:
mozilla74
Tracking Flags:
Tracking Status
firefox74 --- fixed

People

(Reporter: mozilla.org, Unassigned)

References

(
URL
)

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 21096 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/21096
Details from upstream follow.

Marijn Kruisselbrink <mek@chromium.org> wrote:

Add test automation for manual native file system tests.

This adds two new methods to testRunner:

  • getWritableDirectory, which returns the path to an an
    (empty, per test) temporary directory. And
  • setFilePathForMockFileDialog, which causes all file dialogs that
    are shown by the test to return the provided file path.

This is then used to automate the otherwise manual native file system
web platform tests that try to interact with the actual native native
file system implementation (as opposed to the sandboxed file system).

Also rename the filenames of these manual tests so the test system
actually correctly picks them up. Unfortunately not all of the tests
are currently passing, so this also checks in test expectations for
the failing tests.

Bug: 998917
Change-Id: I0c9100d39387bb211c3108c7566937af0e75db68

Reviewed-on: https://chromium-review.googlesource.com/1989369
WPT-Export-Revision: 0922f856ac44ee8d2c977f42da9f97db41eda81c

Pushed by wptsync@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/e96a9ecad0d0
[wpt PR 21096] - Add test automation for manual native file system tests., a=testonly
Test result changes from PR not available.

https://hg.mozilla.org/mozilla-central/rev/e96a9ecad0d0

Status: NEW → RESOLVED
Closed: 4 years ago
status-firefox74: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla74
You need to log in before you can comment on or make changes to this bug.