Closed Bug 1607987 Opened 6 months ago Closed 6 months ago

Split DocumentChannelChild into two classes

Categories

(Core :: Networking, task)

task
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla74
Tracking Status
firefox74 --- fixed

People

(Reporter: mattwoodrow, Assigned: mattwoodrow)

References

Details

Attachments

(1 file)

For bug 1607984 we're going to want a variant of DocumentChannelChild that doesn't use IPDL, but connects in-process to DocumentLoadListener.

I think we want to split most of the logic into DocumentChannelChild into a shared base class (just DocumentChannel?), and have DocumentChannelChild just add the serialization and implementation of PDocumentChannel.

This shouldn't have any functional changes, and adds some new comments to explain the purpose of the classes a bit better.

Depends on D59264

Assignee: nobody → matt.woodrow
Status: NEW → ASSIGNED
Pushed by mwoodrow@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/ca6f43c06131
Split DocumentChannelChild into two classes. r=jya
Pushed by aciure@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/b14fbbbef223
Split DocumentChannelChild into two classes. r=jya
Status: ASSIGNED → RESOLVED
Closed: 6 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla74
Flags: needinfo?(matt.woodrow)
You need to log in before you can comment on or make changes to this bug.