160801 - GB18030 is used for MIME encoded Chinese attachment filename

Status: RESOLVED FIXED

(MailNews Core :: Internationalization, defect)

Description

[ji]

Build: 08/02/02 branch
OS: Simplified Chinese 98/W2K/XP

When attachment filename is in Simplified Chinese, the charset used for filename
mime-encode is gb18030, not gb2312.

Steps to reproduce:
1. Open a mai compose window
2. Attach a file with filename in Simplified Chinese.
3. Send it out to yourself in gb2312.
4. After received, view message source on this mail.
Observe the attachment filename part.

Comment 1

[ji]

Nominating.

Comment 2

[nhottanscp]

For file name, the system charset is used. But the sender's system charset may
not be recoginzed by receivers environment. I think we want to try mail charset
to encode file name first. If it fails then we can fallback to file system charset.

Comment 3

[nhottanscp]

http://lxr.mozilla.org/seamonkey/source/mailnews/compose/src/nsMsgCompUtils.cpp#1540

Comment 4

[nhottanscp]

http://lxr.mozilla.org/seamonkey/source/mailnews/compose/src/nsMsgCompUtils.cpp#752

Comment 5

[nhottanscp]

Attachment: Changed mime_generate_attachment_headers to pass both attachment charset and main body's charset.

Try main body's charset first before using local system charset. 
This is to avoid sending a charset which user may not handle properly (e.g.
GB18030, MacRoman).

Comment 6

[nhottanscp]

Attachment: Added null check for attachment charset.

Comment 7

[Jean-Francois Ducarroz]

Comment on attachment 94264 [details] [diff] [review]
Added null check for attachment charset.

looks good. R=ducarroz

Comment 8

[David :Bienvenu]

+      PR_FREEIF(encodedRealName);
+      encodedRealName = PL_strdup(real_name);
you an just use PR_Free here - it checks for null, and you don't need the
nulling out feature of PR_FREEIF because you're just assigning it on the next
line. Other than that, looks fine.

Comment 9

[David :Bienvenu]

Comment on attachment 94264 [details] [diff] [review]
Added null check for attachment charset.

sr=bienvenu, if you change that PR_FREEIF to PR_Free

Comment 10

[nhottanscp]

checked in to the trunk

Comment 11

[marina]

Jeesun, could you please verify the fix on the today's trunk build on Simplified
Chinese system? Thanks. qa contact to jeesun.

Comment 12

[ji]

Below is some test results with mail clients:
Outlook Express: can handle Chinese attachment file MIME encoded either with
gb18030 and gb2312
Chinese Hotmail: can handle both
Sohu webmail: can handle gb2312, but can't handle gb18030
Sina.com.cn webmail: can't handle gb2312, but can handle gb18030

Comment 13

[ji]

Another info: Outlook Express 6 on Windows XP machine uses gb2312 for attachment
filename by default, it also gives gb18030 and HZ as other options on compose
window.