1608066 - Investigate why test_trr.js fails if speculative-parallel-limit=0

Status: RESOLVED FIXED

(Core :: Networking: DNS, task, P2)

Description

[Valentin Gosu [:valentin] (he/him)]

(In reply to Magnus Melin [:mkmelin] from bug 1607866 comment #11)

The netwerk/test/unit/test_trr.js test perma failures are apparently due to Thunderbird setting network.http.speculative-parallel-limit 0.

Valentin, is this expected? The test works if I add Services.prefs.setIntPref("network.http.speculative-parallel-limit", 6); into the setup()

Comment 1

[Jorg K (CEST = GMT+2)]

Let's not forget to backout as part of the fix here: https://hg.mozilla.org/mozilla-central/rev/da9ee9a09124

Comment 2

[Valentin Gosu [:valentin] (he/him)]

Attachment: Bug 1608066 - Remove skip-if for test_trr.js on thunderbird r=nhnt11

Bug 1694521 fixes the test_trr_flags test by not using channels and
invalid ports - so the speculative connection difference no longer
applies.

Comment 3

[BugBot [:suhaib / :marco/ :calixte]]

There's a r+ patch which didn't land and no activity in this bug for 2 weeks.
:valentin, could you have a look please?
For more information, please visit auto_nag documentation.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/8e3d7b19942b
Remove skip-if for test_trr.js on thunderbird r=nhnt11

Comment 5

[Sandor Molnar[:smolnar]]

Backed out for causing xpc failures in netwerk/test/unit/test_trr.js

Backout link: https://hg.mozilla.org/integration/autoland/rev/9388ed37dcce5adf76715096bf6b2bb3b877959d

Push with failures

Failure log

INFO - TEST-START | security/manager/ssl/tests/unit/test_validity.js
[task 2021-03-21T01:50:55.766Z] 01:50:55 INFO - TEST-PASS | security/manager/ssl/tests/unit/test_validity.js | took 303ms
[task 2021-03-21T01:50:55.769Z] 01:50:55 INFO - Retrying tests that failed when run in parallel.
[task 2021-03-21T01:50:55.773Z] 01:50:55 INFO - TEST-START | netwerk/test/unit/test_trr.js
[task 2021-03-21T01:50:55.995Z] 01:50:55 WARNING - TEST-UNEXPECTED-FAIL | netwerk/test/unit/test_trr.js | xpcshell return code: 0
[task 2021-03-21T01:50:55.995Z] 01:50:55 INFO - TEST-INFO took 214ms
[task 2021-03-21T01:50:55.995Z] 01:50:55 INFO - >>>>>>>
[task 2021-03-21T01:50:55.995Z] 01:50:55 INFO - PID 15985 | start!

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/31266d90b2ca
Remove skip-if for test_trr.js on thunderbird r=nhnt11

Comment 7

[Alexandru Michis [:malexandru]]

https://hg.mozilla.org/mozilla-central/rev/31266d90b2ca