Closed Bug 1608106 Opened 1 year ago Closed 1 year ago

[macOS] Disabled drag space label (ie when title bar is enabled) inside Customize page is barely visible with dark OS theme

Categories

(Firefox :: Toolbars and Customization, defect, P3)

Product:
Firefox
Component:
Toolbars and Customization
Platform:
All
macOS
Type:
defect

Tracking

()

Status:
VERIFIED FIXED
Milestone:
Firefox 74
Tracking Flags:
Tracking Status
firefox-esr68 --- unaffected
firefox72 --- wontfix
firefox73 --- verified
firefox74 --- verified

People

(Reporter: Anca, Assigned: Gijs)

Details

(Keywords: regression)

Attachments

(2 files)

screenshot_issue.png
9.15 KB, image/png
Details
Bug 1608106 - fix drag space label contrast in dark lwthemes, r?nhnt11
47 bytes, text/x-phabricator-request
RyanVM
: approval-mozilla-beta+
Details | Review
Attached image screenshot_issue.png —

[Affected versions]:

  • 72.0.1
  • 73.0b2
  • 74.0a1 (2020-01-07)

[Affected platforms]:

  • macOS 10.14
  • macOS 10.15

[Steps to reproduce]:

  1. Open the Customize page (Menu - Customize)
  2. Check the Title Bar options

[Expected result]:

  • Drag Space options turns inactive, no visual issue can be observed

[Actual result]:

  • Drag Space options turns inactive, but it is hardly visible

[Regression range]:

  • I will provide one asap

[Additional notes]:

  • Issue not reproducible with dark mode on Windows
Has Regression Range: --- → no
Has STR: --- → yes
status-firefox72: affected → wontfix
status-firefox73: affected → fix-optional
Priority: -- → P3
Summary: [macOS] Drag Space label inside Customize page is barely visible with dark OS theme → [macOS] Disabled drag space label (ie when title bar is enabled) inside Customize page is barely visible with dark OS theme
Assignee: nobody → gijskruitbosch+bugs
Status: NEW → ASSIGNED

Bugbug thinks this bug is a regression, but please revert this change in case of error.

Keywords: regression
Pushed by gijskruitbosch@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/b102c4cb93af
fix drag space label contrast in dark lwthemes, r=nhnt11

https://hg.mozilla.org/mozilla-central/rev/b102c4cb93af

Status: ASSIGNED → RESOLVED
Closed: 1 year ago
status-firefox74: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 74

Please nominate this for Beta approval when you get a chance.

status-firefox-esr68: --- → unaffected
Flags: needinfo?(gijskruitbosch+bugs)
Keywords: regressionwindow-wanted

Comment on attachment 9119800 [details]
Bug 1608106 - fix drag space label contrast in dark lwthemes, r?nhnt11

Beta/Release Uplift Approval Request

  • User impact if declined: Unreadable label
  • Is this code covered by automated tests?: No
  • Has the fix been verified in Nightly?: No
  • Needs manual test from QE?: Yes
  • If yes, steps to reproduce: Check the readability of the checkbox label from the summary of this bug in dark themes (cross-platform) and high contrast mode (on Windows).
  • List of other uplifts needed: n/a
  • Risk to taking this patch: Low
  • Why is the change risky/not risky? (and alternatives if risky): Simple CSS fix.
  • String changes made/needed: nope
Flags: needinfo?(gijskruitbosch+bugs)
Attachment #9119800 - Flags: approval-mozilla-beta?
Flags: qe-verify+
Has Regression Range: no → ---
QA Whiteboard: [qa-triaged]

This issue is verified fixed with Fx 74.0a1 (2020-01-15) using dark mode/high contrast on macOS 10.15, Windows 10 x64 and Ubuntu 18.04 x64.

status-firefox74: fixed → verified

Comment on attachment 9119800 [details]
Bug 1608106 - fix drag space label contrast in dark lwthemes, r?nhnt11

Simple fix for a visual glitch. Approved for 73.0b6.

Attachment #9119800 - Flags: approval-mozilla-beta? → approval-mozilla-beta+

(In reply to Anca Soncutean [:Anca], Desktop Release QA from comment #7)

This issue is verified fixed with Fx 74.0a1 (2020-01-15) using dark mode/high contrast on macOS 10.15, Windows 10 x64 and Ubuntu 18.04 x64.

I confirm the issue is verified fixed on Fx 73.0b6 as well across platforms.

Status: RESOLVED → VERIFIED
status-firefox73: fixed → verified
Flags: qe-verify+
You need to log in before you can comment on or make changes to this bug.