1608136 - visualmetrics.py broken on convert call on macOS

Status: RESOLVED FIXED

(Testing :: Raptor, defect, P2)

Description

[Tarek Ziadé (:tarek)]

when visualmetrics is processing the data for the contentful speed index it breaks
with all versions of ImageMagick (6.x, 7.x) because it expects this command:

convert /Users/tarek/Dev/gecko/mozilla-central-opt/browsertime-results/google.com/2020-01-09T143331+0100/pages/google.com/data/video/images/3/ms_001400.png -canny 2x2+8%+8% -define histogram:unique-colors=true -format %c histogram:info:-'

to return something like:

     80883: (0,0,0) #000000 0
       317: (65535,65535,65535) #FFFFFF 255

but it returns grayscales:

     80883: (0,0,0) #000000 gray(0)
       317: (65535,65535,65535) #FFFFFF gray(255)

The fix is to convert the grayscale to an int in there.

Traceback (most recent call last):
  File "/Users/tarek/Dev/gecko/mozilla-central-opt/tools/browsertime/node_modules/browsertime/vendor/visualmetrics.py", line 1909, in main
    options.herodata)
  File "/Users/tarek/Dev/gecko/mozilla-central-opt/tools/browsertime/node_modules/browsertime/vendor/visualmetrics.py", line 1330, in calculate_visual_metrics
    value, value_progress = calculate_contentful_speed_index(progress, dirs)
  File "/Users/tarek/Dev/gecko/mozilla-central-opt/tools/browsertime/node_modules/browsertime/vendor/visualmetrics.py", line 1493, in calculate_contentful_speed_index
    value  = int(output.split()[7].split(':')[0])
ValueError: invalid literal for int() with base 10: 'gray(255)'
``

Comment 1

[Tarek Ziadé (:tarek)]

working on the issue upstream

https://github.com/sitespeedio/browsertime/issues/1091

Comment 2

[Tarek Ziadé (:tarek)]

Attachment: Bug 1608136 - Fixed ContentfulSpeedIndex extraction

The convert output is now parsed in a more robust manner.

Comment 3

[Tarek Ziadé (:tarek)]

let's not merge this yet

Comment 4

[Tarek Ziadé (:tarek)]

we're waiting on two changes by Sean before pinning again here

Comment 5

[Tarek Ziadé (:tarek)]

try run https://treeherder.mozilla.org/#/jobs?repo=try&revision=9cb87e9d569b8237117fb7c22c8e1dfd3bc25ab1

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/14bfbc8cc38d
Fixed ContentfulSpeedIndex extraction r=sparky

Comment 7

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/14bfbc8cc38d