Closed Bug 1608157 Opened 10 months ago Closed 10 months ago

Disable backtrace feature on the failure crate.

Categories

(Toolkit :: Telemetry, defect, P1)

defect

Tracking

()

RESOLVED FIXED
mozilla74
Tracking Status
firefox74 --- fixed

People

(Reporter: janerik, Assigned: janerik)

References

Details

Attachments

(1 file)

See the detailed explanation in the blocked bug: https://bugzilla.mozilla.org/show_bug.cgi?id=1591564#c30

failure is a transitive dependency of a few crates in the dependency graph and its near impossible to disable its backtrace feature completely.
So far it didn't break, but with the FOGotype it starts to break.

This is about using a modified fork of failure that disables backtrace completely.

Some crates in the dependency graph at some point depend on failure,
without disabling its default features, which means they are turned on
for m-c builds.
The default features include the backtrace features, which seems to
cause issues for some m-c builds (like the Windows one).
As we can't turn of default features easily, our next best option is to
use a patched version that doesn't have include backtrace as a default feature.

Original repository: https://github.com/rust-lang-nursery/failure
Base commit: https://github.com/rust-lang-nursery/failure/commit/20f9a9e223b7cd71aed541d050cc73a747fc00c4

Forked repository: https://github.com/badboy/failure
Branch: no-default-backtrace
New commit: https://github.com/badboy/failure/commit/64af847bc5fdcb6d2438bec8a6030812a80519a5

Steps to update after adding the patch line:

cargo update -p gkrust-shared
mach vendor rust

Blocks: 1608360
Blocks: 1608362
Attachment #9119789 - Attachment description: Bug 1608157 - Replace failure with a version that doesn't include backtrace by default → Bug 1608157 - Replace failure with a version that doesn't include backtrace by default r?chutten,emilio
Pushed by jrediger@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/a16ed94b0571
Replace failure with a version that doesn't include backtrace by default r=chutten,emilio
Status: NEW → RESOLVED
Closed: 10 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla74
You need to log in before you can comment on or make changes to this bug.