1608165 - [MSU Capstone] Port toolkit/chrome/mozapps/profile/profileSelection.dtd to Fluent

Status: VERIFIED FIXED

(Toolkit :: Startup and Profile System, task, P3)

Description

[Mike Conley (:mconley) (:⚙️) (PTO: May 24 - June 2nd)]

This DTD appears to be used here:

https://searchfox.org/mozilla-central/rev/be7d1f2d52dd9474ca2df145190a817614c924e4/toolkit/profile/content/profileSelection.xhtml

Comment 1

[Mike Conley (:mconley) (:⚙️) (PTO: May 24 - June 2nd)]

Hey gandalf, Mossop mentioned that this might actually be kind of tricky because the last time he looked, Fluent isn't available before profile-before-change. Is that still true?

Comment 2

[Zibi Braniecki [:zbraniecki][:gandalf]]

Hey gandalf, Mossop mentioned that this might actually be kind of tricky because the last time he looked, Fluent isn't available before profile-before-change. Is that still true?

How is it different from DTD? The API should be available but langpack selection may not be done at this point, which should match the DTD behavior. Am I missing something?

Comment 3

[Dave Townsend [:mossop]]

(In reply to Zibi Braniecki [:zbraniecki][:gandalf] from comment #2)

Hey gandalf, Mossop mentioned that this might actually be kind of tricky because the last time he looked, Fluent isn't available before profile-before-change. Is that still true?

How is it different from DTD? The API should be available but langpack selection may not be done at this point, which should match the DTD behavior. Am I missing something?

Last I checked locale registration hadn't happened before the profile was brought up, so even the built-in locale was not available.

Comment 4

[Zibi Braniecki [:zbraniecki][:gandalf]]

I tested it by adding a <link rel="localization"/> to preferences.ftl and replacing one description with a data-l10n-id backed and it worked well, so I'd expect it to work on par with DTD!

Comment 5

[Mike Conley (:mconley) (:⚙️) (PTO: May 24 - June 2nd)]

Excellent, sounds like this bug is unblocked then. Thanks, gandalf!

Comment 6

[Artem]

Attachment: Bug 1608165 - port profileSelection DTD to fluent r?mconley,gijs

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/44462bd32150
port profileSelection DTD to fluent r=Gijs,fluent-reviewers,flod

Comment 8

[Daniel Varga [:dvarga]]

https://hg.mozilla.org/mozilla-central/rev/44462bd32150

Comment 9

[Bogdan Maris [:bogdan_maris], Release Desktop QA]

Verified fixed as part of PI 551; tested with Nightly 77 across platforms (Windows 10, macOS 10.15 and Ubuntu 18.04).