1608203 - Password manager doesn't fill/remember username for Disney+ on separate page from password field

Status: VERIFIED FIXED

(Toolkit :: Password Manager: Site Compatibility, defect, P2)

Description

[Asif Youssuff]

From: https://www.reddit.com/r/firefox/comments/em3weu/how_can_i_make_firefox_treat_disneypluscomlogin/

https://www.disneyplus.com/login does not offer to remember user's user account (email address). Only after the user account is successfully entered that on the next page, the password manager prompts to save the user's password.

signon.debug showed just:

LoginRecipes: getRecipes: falling back to a synchronous message for: https://www.disneyplus.com

on the login page. I don't have an account, so I was unable to do more troubleshooting.

Comment 1

[Matthew N. [:MattN]]

This is a known issue with multi-page login forms: bug 348941.

If Disney added autocomplete=username to the <input> then we would fix this sooner via bug 1194353 and/or bug 1531164. Ideally Disney+ would have the password field already in the page but hidden and then things would just work.

Comment 2

[Asif Youssuff]

Here is the stuff in the log after the first screen. This is when it already has the password and successfully fills it in after having failed to fill in the email address:

LoginManagerContent: notified before form submission LoginManagerContent.jsm:549:5
LoginManagerContent: _onFormSubmit <unavailable> LoginManagerContent.jsm:1351:5
LoginManagerContent: (form ignored -- no password fields.) LoginManagerContent.jsm:1080:7
LoginManagerContent: onDOMFormHasPassword, visibilityState: visible isMasterPasswordSet: false LoginManagerContent.jsm:606:5
LoginManagerContent: _processDOMFormHasPasswordEvent: <unavailable> <unavailable> LoginManagerContent.jsm:625:5
LoginManagerContent: _detectInsecureFormLikes https://www.disneyplus.com/login/password LoginManagerContent.jsm:792:5
nsLoginManager: searchLogins: formActionOrigin or httpRealm is recommended LoginManager.jsm:467:13
LoginManagerContent: _fillForm <unavailable> LoginManagerContent.jsm:1589:5
LoginManagerContent: (form -- no username field found) LoginManagerContent.jsm:1187:7
LoginManagerContent: Password field <unavailable> has name: password LoginManagerContent.jsm:1206:7
LoginManagerContent: Saving autoFilledLogin {1130250f-c32b-4633-b59a-5e5aabf0179f} for <unavailable>
LoginManagerContent.jsm:1899:9
LoginManagerContent: _fillForm succeeded LoginManagerContent.jsm:1913:7

Comment 3

[Dimi Lee [ooo 29.03 - 07.04]]

This should be fixed by Bug 1708455

Comment 4

[Timea Cernea [:tbabos][inactive]]

Verified-fixed on the latest Nightly 91.0a1 on MacOS 10.15. However, the autocomplete dropdown will be displayed although we already have the username/mail filled in, submitted Bug 1717200 for that.