Closed Bug 1608215 Opened 4 years ago Closed 4 years ago

[MSU Capstone] Port security/manager/chrome/pippki/pippki.dtd to Fluent

Tracking

()

Status:

VERIFIED FIXED

Milestone:

mozilla75

Tracking Flags:

Tracking

Status

firefox75

---

fixed

firefox76

---

fixed

firefox77

---

verified

People

(Reporter: mconley, Assigned: shomalij)

References

(Blocks 1 open bug)

Details

Attachments

(2 files, 1 obsolete file)

bug.diff 4 years ago Julian Shomali 13.73 KB, patch		Details \| Diff \| Splinter Review
Bug 1608215 - port pippki DTD to fluent r?mconley,gijs 4 years ago Julian Shomali 47 bytes, text/x-phabricator-request		Details \| Review
Bug 1608215 - port pippki DTD to fluent: second attempt r?mconley,gijs 4 years ago Julian Shomali 47 bytes, text/x-phabricator-request		Details \| Review

Mike Conley (:mconley) (:⚙️)

Reporter

Description

•

4 years ago

Filing this for some upcoming MSU capstone student work that we hope to do this semester.

This file is used in the following places:

https://searchfox.org/mozilla-central/rev/ba4fab1cc2f1c9c4e07cdb71542b8d441707c577/security/manager/pki/resources/content/changepassword.xhtml
- Can be opened by opening the Browser Console, and typing in
  openDialog("chrome://pippki/content/changepassword.xhtml");
https://searchfox.org/mozilla-central/rev/ba4fab1cc2f1c9c4e07cdb71542b8d441707c577/security/manager/pki/resources/content/clientauthask.xhtml
- Can be opened by opening the Browser Console, and typing in
  openDialog("chrome://pippki/content/clientauthask.xhtml");
https://searchfox.org/mozilla-central/rev/ba4fab1cc2f1c9c4e07cdb71542b8d441707c577/security/manager/pki/resources/content/downloadcert.xhtml
- Can be opened by opening the Browser Console, and typing in
  openDialog("chrome://pippki/content/downloadcert.xhtml");
https://searchfox.org/mozilla-central/rev/ba4fab1cc2f1c9c4e07cdb71542b8d441707c577/security/manager/pki/resources/content/protectedAuth.xhtml
- Can be opened by opening the Browser Console, and typing in
  openDialog("chrome://pippki/content/protectedAuth.xhtml");
https://searchfox.org/mozilla-central/rev/ba4fab1cc2f1c9c4e07cdb71542b8d441707c577/security/manager/pki/resources/content/resetpassword.xhtml
- Can be opened by opening the Browser Console, and typing in
  openDialog("chrome://pippki/content/resetpassword.xhtml");
https://searchfox.org/mozilla-central/rev/ba4fab1cc2f1c9c4e07cdb71542b8d441707c577/security/manager/pki/resources/content/setp12password.xhtml
- Can be opened by opening the Browser Console, and typing in
  openDialog("chrome://pippki/content/setp12password.xhtml");

Mike Conley (:mconley) (:⚙️)

Reporter

Updated

•

4 years ago

Assignee: nobody → shomalij

Mike Conley (:mconley) (:⚙️)

Reporter

Comment 1

•

4 years ago

Hey Julian,

For now, let's put the new .ftl file inside of security/manager/locales/en-US/security/pippki (you're going to need to create the pippki folder).

Julian Shomali

Assignee

Comment 2

•

4 years ago

Attached patch bug.diff — Details — Splinter Review

Mike Conley (:mconley) (:⚙️)

Reporter

Comment 3

•

4 years ago

Apparently two-factor auth is a per-requisite for submitting patches via moz-phab. Julian's phone broke recently, so he can't use a TOTP application on it. And he's not a Mozilla employee, so using DUO is out.

While he's waiting for a new phone, I've had him export the patch and attach it, old-school style.

Julian Shomali

Assignee

Comment 4

•

4 years ago

Attached file Bug 1608215 - port pippki DTD to fluent r?mconley,gijs — Details

Brian Grinstead [:bgrins]

Updated

•

4 years ago

Blocks: 1581212

Julian Shomali

Assignee

Comment 5

•

4 years ago

Attached file Bug 1608215 - port pippki DTD to fluent: second attempt r?mconley,gijs (obsolete) — Details

Depends on D59635

Phabricator Automation

Updated

•

4 years ago

Attachment #9122748 - Attachment is obsolete: true

Pulsebot

Comment 6

•

4 years ago

Pushed by gijskruitbosch@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/53f51116fad1
port pippki DTD to fluent r=Gijs,fluent-reviewers,flod

Daniel Varga [:dvarga]

Comment 7

•

4 years ago

Backed out changeset 53f51116fad1 (Bug 1608215) for causing browser chrome failure at security/manager/ssl/tests/mochitest/browser/browser_clientAuth_ui.js

Push with failure: https://treeherder.mozilla.org/#/jobs?repo=autoland&selectedJob=288512276&searchStr=windows%2C10%2Cx64%2Cquantumrender%2Cdebug%2Cmochitests%2Ctest-windows10-64-qr%2Fdebug-mochitest-browser-chrome-e10s-3%2Cm%28bc3%29&revision=53f51116fad1abce39540565270b5d01145fa946

Failure log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=288512276&repo=autoland&lineNumber=60514

Backout link: https://treeherder.mozilla.org/#/jobs?repo=autoland&resultStatus=testfailed%2Cbusted%2Cexception&classifiedState=unclassified&revision=102cfb52e25eeccba90fa0c9ec35eb8f11264023

[task 2020-02-12T12:46:37.008Z] 12:46:37     INFO - TEST-PASS | security/manager/ssl/tests/mochitest/browser/browser_clientAuth_ui.js | Should be able to find the test client cert - 
[task 2020-02-12T12:46:37.008Z] 12:46:37     INFO - Leaving test bound setup
[task 2020-02-12T12:46:37.008Z] 12:46:37     INFO - Entering test bound testContents
[task 2020-02-12T12:46:37.009Z] 12:46:37     INFO - Console message: [JavaScript Error: "XML Parsing Error: not well-formed
[task 2020-02-12T12:46:37.009Z] 12:46:37     INFO - Location: chrome://pippki/content/clientauthask.xhtml
[task 2020-02-12T12:46:37.009Z] 12:46:37     INFO - Line Number 8, Column 10:" {file: "chrome://pippki/content/clientauthask.xhtml" line: 8 column: 10 source: "<!DOCTYPE>"}]
[task 2020-02-12T12:46:37.009Z] 12:46:37     INFO - Buffered messages finished
[task 2020-02-12T12:46:37.009Z] 12:46:37     INFO - TEST-UNEXPECTED-FAIL | security/manager/ssl/tests/mochitest/browser/browser_clientAuth_ui.js | Uncaught exception - at chrome://mochitests/content/browser/security/manager/ssl/tests/mochitest/browser/browser_clientAuth_ui.js:74 - TypeError: can't access property "textContent", win.document.getElementById(...) is null
[task 2020-02-12T12:46:37.009Z] 12:46:37     INFO - Stack trace:
[task 2020-02-12T12:46:37.009Z] 12:46:37     INFO - checkDialogContents@chrome://mochitests/content/browser/security/manager/ssl/tests/mochitest/browser/browser_clientAuth_ui.js:74:18
[task 2020-02-12T12:46:37.009Z] 12:46:37     INFO - testContents@chrome://mochitests/content/browser/security/manager/ssl/tests/mochitest/browser/browser_clientAuth_ui.js:152:22
[task 2020-02-12T12:46:37.009Z] 12:46:37     INFO - Async*Tester_execTest/<@chrome://mochikit/content/browser-test.js:1062:34
[task 2020-02-12T12:46:37.009Z] 12:46:37     INFO - async*Tester_execTest@chrome://mochikit/content/browser-test.js:1097:11
[task 2020-02-12T12:46:37.009Z] 12:46:37     INFO - nextTest/<@chrome://mochikit/content/browser-test.js:925:14
[task 2020-02-12T12:46:37.009Z] 12:46:37     INFO - SimpleTest.waitForFocus/waitForFocusInner/focusedOrLoaded/<@chrome://mochikit/content/tests/SimpleTest/SimpleTest.js:914:23
[task 2020-02-12T12:46:37.010Z] 12:46:37     INFO - Leaving test bound testContents
[task 2020-02-12T12:46:37.010Z] 12:46:37     INFO - Entering test bound testAcceptDialogReturnValues
[task 2020-02-12T12:46:37.010Z] 12:46:37     INFO - GECKO(8520) | [Parent 4804: Main Thread]: I/DocShellAndDOMWindowLeak ++DOCSHELL 0000025D01766800 == 22 [pid = 4804] [id = {406128cd-5ddd-414b-acf4-a4877dc3e5a8}]
[task 2020-02-12T12:46:37.010Z] 12:46:37     INFO - GECKO(8520) | [Parent 4804: Main Thread]: I/DocShellAndDOMWindowLeak ++DOMWINDOW == 72 (0000025D09BD2980) [pid = 4804] [serial = 81] [outer = 0000000000000000]
[task 2020-02-12T12:46:37.010Z] 12:46:37     INFO - GECKO(8520) | [Parent 4804: Main Thread]: I/DocShellAndDOMWindowLeak ++DOMWINDOW == 73 (0000025D0468C000) [pid = 4804] [serial = 82] [outer = 0000025D09BD2980]
[task 2020-02-12T12:46:37.010Z] 12:46:37     INFO - GECKO(8520) | [Parent 4804, Main Thread] WARNING: NS_ENSURE_TRUE(root) failed: file z:/build/build/src/layout/base/nsDocumentViewer.cpp, line 3135
[task 2020-02-12T12:46:37.073Z] 12:46:37     INFO - GECKO(8520) | [2020-02-12T12:46:37Z WARN  webrender_bindings::bindings] Could not find symbol "glBlendBarrierKHR" by glcontext
[task 2020-02-12T12:46:37.073Z] 12:46:37     INFO - GECKO(8520) | [2020-02-12T12:46:37Z WARN  webrender_bindings::bindings] Could not find symbol "glCopyImageSubDataEXT" by glcontext
[task 2020-02-12T12:46:37.074Z] 12:46:37     INFO - GECKO(8520) | [2020-02-12T12:46:37Z WARN  webrender_bindings::bindings] Could not find symbol "glDebugMessageCallback" by glcontext
[task 2020-02-12T12:46:37.075Z] 12:46:37     INFO - GECKO(8520) | [2020-02-12T12:46:37Z WARN  webrender_bindings::bindings] Could not find symbol "glDebugMessageCallbackARB" by glcontext
[task 2020-02-12T12:46:37.075Z] 12:46:37     INFO - GECKO(8520) | [2020-02-12T12:46:37Z WARN  webrender_bindings::bindings] Could not find symbol "glDebugMessageControl" by glcontext
[task 2020-02-12T12:46:37.075Z] 12:46:37     INFO - GECKO(8520) | [2020-02-12T12:46:37Z WARN  webrender_bindings::bindings] Could not find symbol "glDebugMessageControlARB" by glcontext
[task 2020-02-12T12:46:37.075Z] 12:46:37     INFO - GECKO(8520) | [2020-02-12T12:46:37Z WARN  webrender_bindings::bindings] Could not find symbol "glDebugMessageInsert" by glcontext
[task 2020-02-12T12:46:37.075Z] 12:46:37     INFO - GECKO(8520) | [2020-02-12T12:46:37Z WARN  webrender_bindings::bindings] Could not find symbol "glDebugMessageInsertARB" by glcontext
[task 2020-02-12T12:46:37.075Z] 12:46:37     INFO - GECKO(8520) | [2020-02-12T12:46:37Z WARN  webrender_bindings::bindings] Could not find symbol "glGetDebugMessageLog" by glcontext
[task 2020-02-12T12:46:37.076Z] 12:46:37     INFO - GECKO(8520) | [2020-02-12T12:46:37Z WARN  webrender_bindings::bindings] Could not find symbol "glGetDebugMessageLogARB" by glcontext
[task 2020-02-12T12:46:37.076Z] 12:46:37     INFO - GECKO(8520) | [2020-02-12T12:46:37Z WARN  webrender_bindings::bindings] Could not find symbol "glGetObjectLabel" by glcontext
[task 2020-02-12T12:46:37.076Z] 12:46:37     INFO - GECKO(8520) | [2020-02-12T12:46:37Z WARN  webrender_bindings::bindings] Could not find symbol "glGetObjectPtrLabel" by glcontext
[task 2020-02-12T12:46:37.076Z] 12:46:37     INFO - GECKO(8520) | [2020-02-12T12:46:37Z WARN  webrender_bindings::bindings] Could not find symbol "glObjectLabel" by glcontext
[task 2020-02-12T12:46:37.076Z] 12:46:37     INFO - GECKO(8520) | [2020-02-12T12:46:37Z WARN  webrender_bindings::bindings] Could not find symbol "glObjectPtrLabel" by glcontext
[task 2020-02-12T12:46:37.077Z] 12:46:37     INFO - GECKO(8520) | [2020-02-12T12:46:37Z WARN  webrender_bindings::bindings] Could not find symbol "glPopDebugGroup" by glcontext
[task 2020-02-12T12:46:37.078Z] 12:46:37     INFO - GECKO(8520) | [2020-02-12T12:46:37Z WARN  webrender_bindings::bindings] Could not find symbol "glPushDebugGroup" by glcontext
[task 2020-02-12T12:46:37.078Z] 12:46:37     INFO - GECKO(8520) | [2020-02-12T12:46:37Z WARN  webrender_bindings::bindings] Could not find symbol "glTextureStorage1DEXT" by glcontext
[task 2020-02-12T12:46:37.078Z] 12:46:37     INFO - GECKO(8520) | [2020-02-12T12:46:37Z WARN  webrender_bindings::bindings] Could not find symbol "glTextureStorage2DEXT" by glcontext
[task 2020-02-12T12:46:37.078Z] 12:46:37     INFO - GECKO(8520) | [2020-02-12T12:46:37Z WARN  webrender_bindings::bindings] Could not find symbol "glTextureStorage3DEXT" by glcontext
[task 2020-02-12T12:46:37.117Z] 12:46:37     INFO - Not taking screenshot here: see the one that was previously logged
[task 2020-02-12T12:46:37.117Z] 12:46:37     INFO - TEST-UNEXPECTED-FAIL | security/manager/ssl/tests/mochitest/browser/browser_clientAuth_ui.js | Uncaught exception - at chrome://mochitests/content/browser/security/manager/ssl/tests/mochitest/browser/browser_clientAuth_ui.js:163 - TypeError: can't access property "checked", win.document.getElementById(...) is null
[task 2020-02-12T12:46:37.117Z] 12:46:37     INFO - Stack trace:
[task 2020-02-12T12:46:37.117Z] 12:46:37     INFO - testAcceptDialogReturnValues@chrome://mochitests/content/browser/security/manager/ssl/tests/mochitest/browser/browser_clientAuth_ui.js:163:16
[task 2020-02-12T12:46:37.117Z] 12:46:37     INFO - Async*Tester_execTest/<@chrome://mochikit/content/browser-test.js:1062:34
[task 2020-02-12T12:46:37.117Z] 12:46:37     INFO - async*Tester_execTest@chrome://mochikit/content/browser-test.js:1097:11
[task 2020-02-12T12:46:37.117Z] 12:46:37     INFO - nextTest/<@chrome://mochikit/content/browser-test.js:925:14
[task 2020-02-12T12:46:37.117Z] 12:46:37     INFO - SimpleTest.waitForFocus/waitForFocusInner/focusedOrLoaded/<@chrome://mochikit/content/tests/SimpleTest/SimpleTest.js:914:23
[task 2020-02-12T12:46:37.118Z] 12:46:37     INFO - Leaving test bound testAcceptDialogReturnValues
[task 2020-02-12T12:46:37.118Z] 12:46:37     INFO - Entering test bound testCancelDialogReturnValues

Flags: needinfo?(shomalij)

Pulsebot

Comment 8

•

4 years ago

Pushed by gijskruitbosch@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/c18a78df11fe
port pippki DTD to fluent r=Gijs,fluent-reviewers,flod

Oana Pop-Rus

Comment 9

•

4 years ago

bugherder

https://hg.mozilla.org/mozilla-central/rev/c18a78df11fe

Status: NEW → RESOLVED

Closed: 4 years ago

status-firefox75: --- → fixed

Resolution: --- → FIXED

Target Milestone: --- → mozilla75

:Gijs (he/him)

Updated

•

4 years ago

Flags: needinfo?(shomalij)

Anca Soncutean, Desktop QA

Comment 10

•

4 years ago

Verified fixed as part of PI 551; tested with Nightly 77 across platforms (Windows 10, macOS 10.15 and Ubuntu 18.04).

Status: RESOLVED → VERIFIED

status-firefox77: --- → verified

BugBot [:suhaib / :marco/ :calixte]

Comment 11

•

4 years ago

Since the status are different for nightly and release, what's the status for beta?
For more information, please visit auto_nag documentation.

status-firefox76: --- → ?

Ryan VanderMeulen [:RyanVM]

Updated

•

4 years ago

status-firefox76: ? → fixed

Dana Keeler (she/her) (use needinfo) [:keeler] (on leave)

Updated

•

1 year ago

Depends on: 1804793

You need to log in before you can comment on or make changes to this bug.