1608236 - [Automated review] Reports no test coverage for .cpp file with mochitest coverage (GVAutoplayPermissionRequest.cpp)

Status: NEW

(Developer Infrastructure :: Source Code Analysis, defect, P3)

Description

[Bryce Seager van Dyk [:bryce] (he/him) - Not reading bugmail]

Phabricator URL: https://phabricator.services.mozilla.com/D59404

The bot in this review reports that there is no test coverage for the GVAutoplayPermissionRequest.cpp, however I believe that there is coverage via the mochitests added in https://phabricator.services.mozilla.com/D52807

I'm relatively unfamiliar with how coverage is calculated, so am happy to hear if there's a specific kind of test the expected to provide coverage (or if the bot is correct and our tests are not providing the coverage I expect).

Comment 1

[BugBot [:suhaib / :marco]]

The priority flag is not set for this bug.
:Sylvestre, could you have a look please?

For more information, please visit auto_nag documentation.

Comment 2

[Sylvestre Ledru [:Sylvestre]]

Marco, wdyt? thanks
P3 as it seems rare enough

Comment 3

[Marco Castelluccio [:marco]]

The test is Android-only, that's why we don't have coverage for it yet. It should be rare indeed, if we find it to be frequent we can add the file to the skip list that we are planning to have (bug 1599847).