Closed Bug 1608263 Opened 4 years ago Closed 4 years ago

[wpt-sync] Sync PR 21120 - Revert "[css-grid] Remove outdated css-grid-layout alignment tests"

Categories

(Core :: Layout: Grid, task, P4)

Product:
Core
Component:
Layout: Grid
Type:
task

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla74
Tracking Flags:
Tracking Status
firefox74 --- fixed

People

(Reporter: mozilla.org, Unassigned)

References

(
URL
)

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 21120 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/21120
Details from upstream follow.

Manuel Rego <rego@igalia.com> wrote:

Revert "[css-grid] Remove outdated css-grid-layout alignment tests"

This reverts commit 514a76b7b6287b8e34d200cf51e666d3ee32e511.

Reason for revert: This was removing the tests from the wrong location,
it was removing them from WPT folder instead of fast/css-grid-layout/.

Original change's description:

[css-grid] Remove outdated css-grid-layout alignment tests

The alignment tests in question have been moved from WebKit to WPT
with the following PR:

The removed tests that are now in WPT can be found under:
third_party/blink/web_tests/external/wpt/css/css-grid/alignment/

This patch removes the outdated version of the tests from
third_party/blink/web_tests/fast/css-grid-layout/

Change-Id: I2e5601700332b8fb2e12036f9c45ae7e98bf90b6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1989531
Commit-Queue: Manuel Rego \<rego@igalia.com>
Reviewed-by: Manuel Rego \<rego@igalia.com>
Cr-Commit-Position: refs/heads/master@{#729346}

TBR=jfernandez@igalia.com,rego@igalia.com,obrufau@igalia.com,rmonteriso@igalia.com

Not skipping CQ checks because original CL landed > 1 day ago.

Change-Id: I18d98894d82e9800024d0fd23ee11c82432a0e64

Reviewed-on: https://chromium-review.googlesource.com/1993801
WPT-Export-Revision: c2f906f1c144638c8bc2cbf2dfeca1dfe9b53f50

Component: web-platform-tests → Layout: Grid
Product: Testing → Core

CI Results

Ran 0 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 3 tests and 24 subtests

Status Summary

Firefox

OK : 3
PASS: 18
FAIL: 54

Chrome

OK : 3
PASS: 14
FAIL: 58

Safari

OK : 3
PASS: 18
FAIL: 54

Links

GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

/css/css-grid/alignment/grid-align-content-distribution-vertical-rl.html
.grid 19: FAIL (Chrome: FAIL, Safari: FAIL)
.grid 18: FAIL (Chrome: FAIL, Safari: FAIL)
.grid 15: FAIL (Chrome: FAIL, Safari: FAIL)
.grid 14: FAIL (Chrome: FAIL, Safari: FAIL)
.grid 17: FAIL (Chrome: FAIL, Safari: FAIL)
.grid 11: FAIL (Chrome: FAIL, Safari: FAIL)
.grid 10: FAIL (Chrome: FAIL, Safari: FAIL)
.grid 13: FAIL (Chrome: FAIL, Safari: FAIL)
.grid 1: FAIL (Chrome: FAIL, Safari: FAIL)
.grid 3: FAIL (Chrome: FAIL, Safari: FAIL)
.grid 2: FAIL (Chrome: FAIL, Safari: FAIL)
.grid 5: FAIL (Chrome: FAIL, Safari: FAIL)
.grid 7: FAIL (Chrome: FAIL, Safari: FAIL)
.grid 6: FAIL (Chrome: FAIL, Safari: FAIL)
.grid 9: FAIL (Chrome: FAIL, Safari: FAIL)
.grid 21: FAIL (Chrome: FAIL, Safari: FAIL)
.grid 22: FAIL (Chrome: FAIL, Safari: FAIL)
.grid 23: FAIL (Chrome: FAIL, Safari: FAIL)
/css/css-grid/alignment/grid-align-content-distribution-vertical-lr.html
.grid 19: FAIL (Chrome: FAIL, Safari: FAIL)
.grid 18: FAIL (Chrome: FAIL, Safari: FAIL)
.grid 15: FAIL (Chrome: FAIL, Safari: FAIL)
.grid 14: FAIL (Chrome: FAIL, Safari: FAIL)
.grid 17: FAIL (Chrome: FAIL, Safari: FAIL)
.grid 11: FAIL (Chrome: FAIL, Safari: FAIL)
.grid 10: FAIL (Chrome: FAIL, Safari: FAIL)
.grid 13: FAIL (Chrome: FAIL, Safari: FAIL)
.grid 1: FAIL (Chrome: FAIL, Safari: FAIL)
.grid 3: FAIL (Chrome: FAIL, Safari: FAIL)
.grid 2: FAIL (Chrome: FAIL, Safari: FAIL)
.grid 5: FAIL (Chrome: FAIL, Safari: FAIL)
.grid 7: FAIL (Chrome: FAIL, Safari: FAIL)
.grid 6: FAIL (Chrome: FAIL, Safari: FAIL)
.grid 9: FAIL (Chrome: FAIL, Safari: FAIL)
.grid 21: FAIL (Chrome: FAIL, Safari: FAIL)
.grid 22: FAIL (Chrome: FAIL, Safari: FAIL)
.grid 23: FAIL (Chrome: FAIL, Safari: FAIL)
/css/css-grid/alignment/grid-align-content-distribution.html
.grid 19: FAIL (Chrome: FAIL, Safari: FAIL)
.grid 18: FAIL (Chrome: FAIL, Safari: FAIL)
.grid 15: FAIL (Chrome: FAIL, Safari: FAIL)
.grid 14: FAIL (Chrome: FAIL, Safari: FAIL)
.grid 17: FAIL (Chrome: FAIL, Safari: FAIL)
.grid 11: FAIL (Chrome: FAIL, Safari: FAIL)
.grid 10: FAIL (Chrome: FAIL, Safari: FAIL)
.grid 13: FAIL (Chrome: FAIL, Safari: FAIL)
.grid 1: FAIL (Chrome: FAIL, Safari: FAIL)
.grid 3: FAIL (Chrome: FAIL, Safari: FAIL)
.grid 2: FAIL (Chrome: FAIL, Safari: FAIL)
.grid 5: FAIL (Chrome: FAIL, Safari: FAIL)
.grid 7: FAIL (Chrome: FAIL, Safari: FAIL)
.grid 6: FAIL (Chrome: FAIL, Safari: FAIL)
.grid 9: FAIL (Chrome: FAIL, Safari: FAIL)
.grid 21: FAIL (Chrome: FAIL, Safari: FAIL)
.grid 22: FAIL (Chrome: FAIL, Safari: FAIL)
.grid 23: FAIL (Chrome: FAIL, Safari: FAIL)

Pushed by wptsync@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/8bfc956e516a
[wpt PR 21120] - Revert "[css-grid] Remove outdated css-grid-layout alignment tests", a=testonly

https://hg.mozilla.org/mozilla-central/rev/8bfc956e516a

Status: NEW → RESOLVED
Closed: 4 years ago
status-firefox74: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla74
You need to log in before you can comment on or make changes to this bug.